Remove deprecated ListValue::Append(Value*) overload on Linux.

chrome/browser/signin/signin_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/signin/core/browser/signin_manager.h"
 
 #include <memory>
 #include <utility>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/compiler_specific.h"
+#include "base/memory/ptr_util.h"
 #include "base/run_loop.h"
 #include "base/strings/stringprintf.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/prefs/browser_prefs.h"
 #include "chrome/browser/signin/account_fetcher_service_factory.h"
 #include "chrome/browser/signin/account_tracker_service_factory.h"
 #include "chrome/browser/signin/chrome_signin_client_factory.h"
 #include "chrome/browser/signin/fake_account_fetcher_service_builder.h"
 #include "chrome/browser/signin/fake_profile_oauth2_token_service_builder.h"
@@ skipping 474 matching lines @@
     std::string gaia_id = "account_gaia_id";
 
     CreateNakedSigninManager();
 
     PrefService* client_prefs = signin_client()->GetPrefs();
     client_prefs->SetInteger(prefs::kAccountIdMigrationState,
                              AccountTrackerService::MIGRATION_NOT_STARTED);
     ListPrefUpdate update(client_prefs,
                           AccountTrackerService::kAccountInfoPref);
     update->Clear();
-    base::DictionaryValue* dict = new base::DictionaryValue();
-    update->Append(dict);
+    auto dict = base::MakeUnique<base::DictionaryValue>();
     dict->SetString("account_id", base::UTF8ToUTF16(email));
     dict->SetString("email", base::UTF8ToUTF16(email));
     dict->SetString("gaia", base::UTF8ToUTF16(gaia_id));
+    update->Append(std::move(dict));
 
     tracker->Shutdown();
     tracker->Initialize(signin_client());
 
     client_prefs->SetString(prefs::kGoogleServicesAccountId, email);
     manager_->Initialize(g_browser_process->local_state());
 
     EXPECT_EQ(gaia_id, manager_->GetAuthenticatedAccountId());
     EXPECT_EQ(gaia_id, profile()->GetPrefs()->GetString(
                            prefs::kGoogleServicesAccountId));
   }
 }
 
 TEST_F(SigninManagerTest, VeryOldProfileGaiaIdMigration) {
   AccountTrackerService* tracker =
       AccountTrackerServiceFactory::GetForProfile(profile());
   if (tracker->GetMigrationState() !=
       AccountTrackerService::MIGRATION_NOT_STARTED) {
     std::string email = "user@gmail.com";
     std::string gaia_id = "account_gaia_id";
 
     CreateNakedSigninManager();
 
     PrefService* client_prefs = signin_client()->GetPrefs();
     client_prefs->SetInteger(prefs::kAccountIdMigrationState,
                              AccountTrackerService::MIGRATION_NOT_STARTED);
     ListPrefUpdate update(client_prefs,
                           AccountTrackerService::kAccountInfoPref);
     update->Clear();
-    base::DictionaryValue* dict = new base::DictionaryValue();
-    update->Append(dict);
+    auto dict = base::MakeUnique<base::DictionaryValue>();
     dict->SetString("account_id", base::UTF8ToUTF16(email));
     dict->SetString("email", base::UTF8ToUTF16(email));
     dict->SetString("gaia", base::UTF8ToUTF16(gaia_id));
+    update->Append(std::move(dict));
 
     tracker->Shutdown();
     tracker->Initialize(signin_client());
 
     client_prefs->ClearPref(prefs::kGoogleServicesAccountId);
     client_prefs->SetString(prefs::kGoogleServicesUsername, email);
     manager_->Initialize(g_browser_process->local_state());
 
     EXPECT_EQ(gaia_id, manager_->GetAuthenticatedAccountId());
     EXPECT_EQ(gaia_id, profile()->GetPrefs()->GetString(
@@ skipping 10 matching lines @@
     std::string gaia_id = "account_gaia_id";
 
     CreateNakedSigninManager();
 
     PrefService* client_prefs = signin_client()->GetPrefs();
     client_prefs->SetInteger(prefs::kAccountIdMigrationState,
                              AccountTrackerService::MIGRATION_NOT_STARTED);
     ListPrefUpdate update(client_prefs,
                           AccountTrackerService::kAccountInfoPref);
     update->Clear();
-    base::DictionaryValue* dict = new base::DictionaryValue();
-    update->Append(dict);
+    auto dict = base::MakeUnique<base::DictionaryValue>();
     dict->SetString("account_id", base::UTF8ToUTF16(email));
     dict->SetString("email", base::UTF8ToUTF16(email));
     dict->SetString("gaia", base::UTF8ToUTF16(gaia_id));
+    update->Append(std::move(dict));
 
     tracker->Shutdown();
     tracker->Initialize(signin_client());
 
     client_prefs->SetString(prefs::kGoogleServicesAccountId, gaia_id);
     manager_->Initialize(g_browser_process->local_state());
 
     EXPECT_EQ(gaia_id, manager_->GetAuthenticatedAccountId());
     EXPECT_EQ(gaia_id, profile()->GetPrefs()->GetString(
                            prefs::kGoogleServicesAccountId));
 
     base::RunLoop().RunUntilIdle();
     EXPECT_EQ(AccountTrackerService::MIGRATION_DONE,
               tracker->GetMigrationState());
   }
 }