third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py - Issue 2014063002: Run format-webkit on webkitpy code (without string conversion).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py

Issue 2014063002: Run format-webkit on webkitpy code (without string conversion). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations.py ('K') | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_input.py » ('j') | third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py

index 7b5fc84eb9a97ed4f0b472bbb457122152bd4997..37de000cf722033414784b2b6426c7c4c76ee2d2 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py

@@ -33,7 +33,8 @@ from webkitpy.layout_tests.models import test_expectations

def is_reftest_failure(failure_list):

failure_types = [type(f) for f in failure_list]

- return set((FailureReftestMismatch, FailureReftestMismatchDidNotOccur, FailureReftestNoImagesGenerated)).intersection(failure_types)

+ return set((FailureReftestMismatch, FailureReftestMismatchDidNotOccur, FailureReftestNoImagesGenerated)).intersection(

+ failure_types)

# FIXME: This is backwards. Each TestFailure subclass should know what

# test_expectation type it corresponds too. Then this method just

@@ -85,6 +86,7 @@ def determine_result_type(failure_list):

class TestFailure(object):

"""Abstract base class that defines the failure interface."""

@staticmethod