Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: mojo/common/tracing_impl.h

Issue 2014043002: Make TracingImpl take a Shell* and args, instead of an ApplicationImpl*. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « examples/trace_me/trace_me_app.cc ('k') | mojo/common/tracing_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/common/tracing_impl.h
diff --git a/mojo/common/tracing_impl.h b/mojo/common/tracing_impl.h
index d3f93c6426d47c2ec829a74d63c6b8d9d0e89453..95c44eaefab345ab6196f2ff1ea9635ab893c7b5 100644
--- a/mojo/common/tracing_impl.h
+++ b/mojo/common/tracing_impl.h
@@ -5,12 +5,15 @@
#ifndef MOJO_COMMON_TRACING_IMPL_H_
#define MOJO_COMMON_TRACING_IMPL_H_
+#include <string>
+#include <vector>
+
#include "base/macros.h"
#include "mojo/common/trace_provider_impl.h"
namespace mojo {
-class ApplicationImpl;
+class Shell;
class TracingImpl {
public:
@@ -18,8 +21,10 @@ class TracingImpl {
~TracingImpl();
// This connects to the tracing service and registers ourselves to provide
- // tracing data on demand.
- void Initialize(ApplicationImpl* app);
+ // tracing data on demand. |shell| will not be stored (so it need only be
+ // valid for this call). |args| may be null, but if not should typically point
+ // to the applications "command line".
+ void Initialize(Shell* shell, const std::vector<std::string>* args);
private:
TraceProviderImpl provider_impl_;
« no previous file with comments | « examples/trace_me/trace_me_app.cc ('k') | mojo/common/tracing_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698