skia/public/interfaces/skbitmap.typemap - Issue 2014013002: Add SkBitmap StructTraits for skia::mojo::Bitmap.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: skia/public/interfaces/skbitmap.typemap

Issue 2014013002: Add SkBitmap StructTraits for skia::mojo::Bitmap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add mojo/public/cpp/bindings typemap deps. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« skia/public/interfaces/bitmap_skbitmap_struct_traits.h ('K') | « skia/public/interfaces/bitmap_skbitmap_struct_traits.h ('k') | skia/public/interfaces/typemaps.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 mojom = "//skia/public/interfaces/bitmap.mojom"

	6 public_headers = [ "//third_party/skia/include/core/SkBitmap.h" ]

	7 traits_headers = [ "//skia/public/interfaces/bitmap_skbitmap_struct_traits.h" ]

	8 deps = [ "//mojo/public/cpp/bindings" ]
	yzshen1 2016/05/26 22:44:13 I think this is not necessary. Right? I think this is not necessary. Right? msw 2016/05/27 19:34:11 This fixes the analyze step failure from the prior Show quoted text On 2016/05/26 22:44:13, yzshen1 wrote: > I think this is not necessary. Right? This fixes the analyze step failure from the prior patch set: https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium... ERROR at //skia/public/interfaces/bitmap_skbitmap_struct_traits.h:8:11: Include not allowed. #include "mojo/public/cpp/bindings/array_traits.h" ^-------------------------------------- It is not in any dependency of //skia/public/interfaces:interfaces_cpp_sources The include file is in the target(s): //mojo/public/cpp/bindings:bindings yzshen1 2016/05/31 23:17:36 Ah, I see. Thanks! Show quoted text On 2016/05/27 19:34:11, msw wrote: > On 2016/05/26 22:44:13, yzshen1 wrote: > > I think this is not necessary. Right? > > This fixes the analyze step failure from the prior patch set: > https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium... > ERROR at //skia/public/interfaces/bitmap_skbitmap_struct_traits.h:8:11: Include > not allowed. > #include "mojo/public/cpp/bindings/array_traits.h" > ^-------------------------------------- > It is not in any dependency of > //skia/public/interfaces:interfaces_cpp_sources > The include file is in the target(s): > //mojo/public/cpp/bindings:bindings Ah, I see. Thanks!
	9 public_deps = [ "//skia" ]

	10 type_mappings = [ "skia.mojom.Bitmap=SkBitmap" ]

OLD	NEW