Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2013963005: Replace FXJSE_HCONTEXT with CFXJSE_Context* (Closed)

Created:
4 years, 7 months ago by dsinclair
Modified:
4 years, 7 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Replace FXJSE_HCONTEXT with CFXJSE_Context* This Cl removes FXJSE_HCONTEXT and replaces it with the concrete CFXJSE_Context. All varibles have been updated as well to match the new type. Committed: https://pdfium.googlesource.com/pdfium/+/7f2abcc015583e63cceb52acde757cb2111420bd

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : Merge to master #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -102 lines) Patch
M xfa/fxfa/fm2js/xfa_fm2jsapi.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jsapi.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jscontext.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jscontext.cpp View 1 2 3 chunks +8 lines, -8 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_imp.h View 1 2 chunks +6 lines, -6 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_imp.cpp View 1 2 11 chunks +31 lines, -31 lines 0 comments Download
M xfa/fxjse/class.cpp View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M xfa/fxjse/context.h View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fxjse/context.cpp View 2 chunks +10 lines, -22 lines 0 comments Download
M xfa/fxjse/include/fxjse.h View 1 2 3 chunks +9 lines, -10 lines 0 comments Download
M xfa/fxjse/value.h View 1 2 6 chunks +8 lines, -14 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
dsinclair
PTAL.
4 years, 7 months ago (2016-05-26 13:25:14 UTC) #4
Tom Sepez
lgtm
4 years, 7 months ago (2016-05-26 15:55:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013963005/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013963005/100001
4 years, 7 months ago (2016-05-26 16:04:25 UTC) #8
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 7 months ago (2016-05-26 16:04:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013963005/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013963005/120001
4 years, 7 months ago (2016-05-26 16:09:17 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 16:40:31 UTC) #15
Message was sent while issue was closed. 
Committed patchset #4 (id:120001) as
https://pdfium.googlesource.com/pdfium/+/7f2abcc015583e63cceb52acde757cb21114...

Powered by Google App Engine
This is Rietveld 408576698