Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2013963003:
Add the Mac OSX Keychain message to the Passwords Page. (Closed)
|
Created:
4 years, 7 months ago by hcarmona Modified:
4 years, 7 months ago CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd the Mac OSX Keychain message to the Passwords Page.
BUG=614580
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/d0fafa15a74139bf3debb530f21414797fee85f9
Cr-Commit-Position: refs/heads/master@{#396316}
Patch Set 1 : #
Total comments: 8
Patch Set 2 : Simplify #Messages
Total messages: 17 (8 generated)
Description was changed from ========== Add the Mac OSX Keychain message to the Passwords Page. BUG=614580 ========== to ========== Add the Mac OSX Keychain message to the Passwords Page. BUG=614580 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
Patchset #1 (id:1) has been deleted
Description was changed from ========== Add the Mac OSX Keychain message to the Passwords Page. BUG=614580 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== Add the Mac OSX Keychain message to the Passwords Page. BUG=614580 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
hcarmona@chromium.org changed reviewers: + dschuyler@chromium.org
PTAL, this is a mac-only change. Thanks!
dbeam@chromium.org changed reviewers: + dbeam@chromium.org
https://codereview.chromium.org/2013963003/diff/20001/chrome/app/settings_str... File chrome/app/settings_strings.grdp (right): https://codereview.chromium.org/2013963003/diff/20001/chrome/app/settings_str... chrome/app/settings_strings.grdp:270: On Mac, passwords may be saved to your Keycahin and accessed or synced by other Chrome users sharing this OS X account. Keychain https://codereview.chromium.org/2013963003/diff/20001/chrome/browser/resource... File chrome/browser/resources/settings/settings_resources.grd (right): https://codereview.chromium.org/2013963003/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/settings_resources.grd:473: flattenhtml="true" nit: can this be preprocess=true now instead? https://codereview.chromium.org/2013963003/diff/20001/chrome/browser/ui/webui... File chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc (left): https://codereview.chromium.org/2013963003/diff/20001/chrome/browser/ui/webui... chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:644: {"overflowMenu", IDS_SETTINGS_OVERFLOW_MENU}, did clang format do this? 4\s is correct (AFAIK) in C++ (which differs from JS)
https://codereview.chromium.org/2013963003/diff/20001/chrome/app/settings_str... File chrome/app/settings_strings.grdp (right): https://codereview.chromium.org/2013963003/diff/20001/chrome/app/settings_str... chrome/app/settings_strings.grdp:265: Access your passwords from any device at <ph name="BEGIN_LINK"><a is="action-link" href="$1" target="_blank"></ph>passwords.google.com<ph name="END_LINK"></a></ph>. because this didn't have a period at the end until this Mac string came along, maybe this CL should do: <if expr="is_macosx"> <then> <message name="IDS_SETTINGS_PASSWORDS_MANAGE_PASSWORDS" desc="..."> Access your passwords from any device at <ph name="BEGIN_LINK"><a is="action-link" href="$1" target="_blank"></ph>passwords.google.com<ph name="END_LINK"></a></ph>. On Mac, passwords may be saved to your Keycahin and accessed or synced by other Chrome users sharing this OS X account. </message> </then> <else> <message name="IDS_SETTINGS_PASSWORDS_MANAGE_PASSWORDS" desc="..."> Access your passwords from any device at <ph name="BEGIN_LINK"><a is="action-link" href="$1" target="_blank"></ph>passwords.google.com<ph name="END_LINK"></a></ph> </message> </else> </if> and drop the second string / other changes. wdyt?
https://codereview.chromium.org/2013963003/diff/20001/chrome/app/settings_str... File chrome/app/settings_strings.grdp (right): https://codereview.chromium.org/2013963003/diff/20001/chrome/app/settings_str... chrome/app/settings_strings.grdp:265: Access your passwords from any device at <ph name="BEGIN_LINK"><a is="action-link" href="$1" target="_blank"></ph>passwords.google.com<ph name="END_LINK"></a></ph>. On 2016/05/26 19:03:11, Dan Beam wrote: > because this didn't have a period at the end until this Mac string came along, > maybe this CL should do: > > <if expr="is_macosx"> > <then> > <message name="IDS_SETTINGS_PASSWORDS_MANAGE_PASSWORDS" desc="..."> > Access your passwords from any device at <ph name="BEGIN_LINK"><a > is="action-link" href="$1" target="_blank"></ph>passwords.google.com<ph > name="END_LINK"></a></ph>. On Mac, passwords may be saved to your Keycahin > and accessed or synced by other Chrome users sharing this OS X account. > </message> > </then> > <else> > <message name="IDS_SETTINGS_PASSWORDS_MANAGE_PASSWORDS" desc="..."> > Access your passwords from any device at <ph name="BEGIN_LINK"><a > is="action-link" href="$1" target="_blank"></ph>passwords.google.com<ph > name="END_LINK"></a></ph> > </message> > </else> > </if> > > and drop the second string / other changes. wdyt? Sounds good. Updated. https://codereview.chromium.org/2013963003/diff/20001/chrome/app/settings_str... chrome/app/settings_strings.grdp:270: On Mac, passwords may be saved to your Keycahin and accessed or synced by other Chrome users sharing this OS X account. On 2016/05/26 18:57:28, Dan Beam wrote: > Keychain Done. https://codereview.chromium.org/2013963003/diff/20001/chrome/browser/resource... File chrome/browser/resources/settings/settings_resources.grd (right): https://codereview.chromium.org/2013963003/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/settings_resources.grd:473: flattenhtml="true" On 2016/05/26 18:57:28, Dan Beam wrote: > nit: can this be preprocess=true now instead? Not needed anymore. https://codereview.chromium.org/2013963003/diff/20001/chrome/browser/ui/webui... File chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc (left): https://codereview.chromium.org/2013963003/diff/20001/chrome/browser/ui/webui... chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc:644: {"overflowMenu", IDS_SETTINGS_OVERFLOW_MENU}, On 2016/05/26 18:57:28, Dan Beam wrote: > did clang format do this? 4\s is correct (AFAIK) in C++ (which differs from JS) Yes, ran format. Not needed anymore.
lgtm
The CQ bit was checked by hcarmona@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013963003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013963003/40001
Message was sent while issue was closed.
Description was changed from ========== Add the Mac OSX Keychain message to the Passwords Page. BUG=614580 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== Add the Mac OSX Keychain message to the Passwords Page. BUG=614580 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Add the Mac OSX Keychain message to the Passwords Page. BUG=614580 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== Add the Mac OSX Keychain message to the Passwords Page. BUG=614580 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/d0fafa15a74139bf3debb530f21414797fee85f9 Cr-Commit-Position: refs/heads/master@{#396316} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/d0fafa15a74139bf3debb530f21414797fee85f9 Cr-Commit-Position: refs/heads/master@{#396316} |
