Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayer.cpp

Issue 2013953002: Remove inlineBoundingBoxOffset from PaintLayer::updateLayerPosition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/paint/PaintLayer.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintLayer.cpp b/third_party/WebKit/Source/core/paint/PaintLayer.cpp
index 066bd0231c041e4ee4e238c2b40d788c9db32a55..91ca71f824c3c542f969e38fcd815f36a13415f4 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayer.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintLayer.cpp
@@ -756,14 +756,11 @@ bool PaintLayer::update3DTransformedDescendantStatus()
void PaintLayer::updateLayerPosition()
{
LayoutPoint localPoint;
- LayoutPoint inlineBoundingBoxOffset; // We don't put this into the Layer x/y for inlines, so we need to subtract it out when done.
if (layoutObject()->isInline() && layoutObject()->isLayoutInline()) {
LayoutInline* inlineFlow = toLayoutInline(layoutObject());
IntRect lineBox = enclosingIntRect(inlineFlow->linesBoundingBox());
m_size = lineBox.size();
- inlineBoundingBoxOffset = lineBox.location();
- localPoint.moveBy(inlineBoundingBoxOffset);
} else if (LayoutBox* box = layoutBox()) {
m_size = pixelSnappedIntSize(box->size(), box->location());
localPoint.moveBy(box->topLeftLocation());
@@ -813,9 +810,6 @@ void PaintLayer::updateLayerPosition()
m_rareData->offsetForInFlowPosition = LayoutSize();
}
- // FIXME: We'd really like to just get rid of the concept of a layer rectangle and rely on the layoutObjects.
- localPoint.moveBy(-inlineBoundingBoxOffset);
-
if (m_location != localPoint) {
setNeedsRepaint();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698