fix signed warning errors in unittests

fix signed warning errors in unittests

A bunch of gtest assert statements fail due to signed warnings as
unadorned constants are treated as signed integers.  Mark them all
unsigned to avoid that.

One example (focus on the "[with ...]" blocks that show the types):
In file included from src/breakpad_googletest_includes.h:33:0,
                 from src/common/memory_unittest.cc:30:
src/testing/gtest/include/gtest/gtest.h: In instantiation of 'testing::AssertionResult testing::internal::CmpHelperEQ(const char*, const char*, const T1&, const T2&) [with T1 = int; T2 = long unsigned int]':
src/testing/gtest/include/gtest/gtest.h:1524:23: required from 'static testing::AssertionResult testing::internal::EqHelper<true>::Compare(const char*, const char*, const T1&, const T2&, typename testing::internal::EnableIf<(! testing::internal::is_pointer<T2>::value)>::type*) [with T1 = int; T2 = long unsigned int; typename testing::internal::EnableIf<(! testing::internal::is_pointer<T2>::value)>::type = void]'
src/common/memory_unittest.cc:41:246: required from here
src/testing/gtest/include/gtest/gtest.h:1448:16: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
   if (expected == actual) {
                ^
cc1plus: some warnings being treated as errors
Makefile:5180: recipe for target 'src/common/src_client_linux_linux_client_unittest_shlib-memory_unittest.o' failed
make[2]: *** [src/common/src_client_linux_linux_client_unittest_shlib-memory_unittest.o] Error 1

R=ted.mielczarek@gmail.com

Committed: https://chromium.googlesource.com/breakpad/breakpad/+/bad9e55ea52abd1bb759b800d85aa8952e315af1

[vapier, 2016-05-25 18:49:04]

vapier@chromium.org changed reviewers:
+ ted@mielczarek.org

[vapier, 2016-05-25 18:49:05]

bouncing to you Ted as the memory_unittest.cc ones seem to come from the recent
https://codereview.chromium.org/1688743002

[vapier, 2016-05-25 18:49:14]

Description was changed from

==========
fix signed warning errors in unittests

A bunch of gtest assert statements fail due to signed warnings as
unadorned constants are treated as signed integers.  Mark them all
unsigned to avoid that.

One example (focus on the "[with ...]" blocks that show the types):
In file included from src/breakpad_googletest_includes.h:33:0,
                 from src/common/memory_unittest.cc:30:
src/testing/gtest/include/gtest/gtest.h: In instantiation of
'testing::AssertionResult testing::internal::CmpHelperEQ(const char*, const
char*, const T1&, const T2&) [with T1 = int; T2 = long unsigned int]':
src/testing/gtest/include/gtest/gtest.h:1524:23: required from 'static
testing::AssertionResult testing::internal::EqHelper<true>::Compare(const char*,
const char*, const T1&, const T2&, typename testing::internal::EnableIf<(!
testing::internal::is_pointer<T2>::value)>::type*) [with T1 = int; T2 = long
unsigned int; typename testing::internal::EnableIf<(!
testing::internal::is_pointer<T2>::value)>::type = void]'
src/common/memory_unittest.cc:41:246: required from here
src/testing/gtest/include/gtest/gtest.h:1448:16: error: comparison between
signed and unsigned integer expressions [-Werror=sign-compare]
   if (expected == actual) {
                ^
cc1plus: some warnings being treated as errors
Makefile:5180: recipe for target
'src/common/src_client_linux_linux_client_unittest_shlib-memory_unittest.o'
failed
make[2]: ***
[src/common/src_client_linux_linux_client_unittest_shlib-memory_unittest.o]
Error 1

BUG=
==========

to

==========
fix signed warning errors in unittests

A bunch of gtest assert statements fail due to signed warnings as
unadorned constants are treated as signed integers.  Mark them all
unsigned to avoid that.

One example (focus on the "[with ...]" blocks that show the types):
In file included from src/breakpad_googletest_includes.h:33:0,
                 from src/common/memory_unittest.cc:30:
src/testing/gtest/include/gtest/gtest.h: In instantiation of
'testing::AssertionResult testing::internal::CmpHelperEQ(const char*, const
char*, const T1&, const T2&) [with T1 = int; T2 = long unsigned int]':
src/testing/gtest/include/gtest/gtest.h:1524:23: required from 'static
testing::AssertionResult testing::internal::EqHelper<true>::Compare(const char*,
const char*, const T1&, const T2&, typename testing::internal::EnableIf<(!
testing::internal::is_pointer<T2>::value)>::type*) [with T1 = int; T2 = long
unsigned int; typename testing::internal::EnableIf<(!
testing::internal::is_pointer<T2>::value)>::type = void]'
src/common/memory_unittest.cc:41:246: required from here
src/testing/gtest/include/gtest/gtest.h:1448:16: error: comparison between
signed and unsigned integer expressions [-Werror=sign-compare]
   if (expected == actual) {
                ^
cc1plus: some warnings being treated as errors
Makefile:5180: recipe for target
'src/common/src_client_linux_linux_client_unittest_shlib-memory_unittest.o'
failed
make[2]: ***
[src/common/src_client_linux_linux_client_unittest_shlib-memory_unittest.o]
Error 1
==========

[Ted Mielczarek, 2016-05-26 10:17:33]

ted.mielczarek@gmail.com changed reviewers:
+ ted.mielczarek@gmail.com

[Ted Mielczarek, 2016-05-26 10:17:34]

LGTM

Should we fix the Travis build to match the Chromium build configuration? Is
this just building with -Werror, or is this building with clang?

[vapier, 2016-05-26 14:09:51]

Description was changed from

==========
fix signed warning errors in unittests

A bunch of gtest assert statements fail due to signed warnings as
unadorned constants are treated as signed integers.  Mark them all
unsigned to avoid that.

One example (focus on the "[with ...]" blocks that show the types):
In file included from src/breakpad_googletest_includes.h:33:0,
                 from src/common/memory_unittest.cc:30:
src/testing/gtest/include/gtest/gtest.h: In instantiation of
'testing::AssertionResult testing::internal::CmpHelperEQ(const char*, const
char*, const T1&, const T2&) [with T1 = int; T2 = long unsigned int]':
src/testing/gtest/include/gtest/gtest.h:1524:23: required from 'static
testing::AssertionResult testing::internal::EqHelper<true>::Compare(const char*,
const char*, const T1&, const T2&, typename testing::internal::EnableIf<(!
testing::internal::is_pointer<T2>::value)>::type*) [with T1 = int; T2 = long
unsigned int; typename testing::internal::EnableIf<(!
testing::internal::is_pointer<T2>::value)>::type = void]'
src/common/memory_unittest.cc:41:246: required from here
src/testing/gtest/include/gtest/gtest.h:1448:16: error: comparison between
signed and unsigned integer expressions [-Werror=sign-compare]
   if (expected == actual) {
                ^
cc1plus: some warnings being treated as errors
Makefile:5180: recipe for target
'src/common/src_client_linux_linux_client_unittest_shlib-memory_unittest.o'
failed
make[2]: ***
[src/common/src_client_linux_linux_client_unittest_shlib-memory_unittest.o]
Error 1
==========

to

==========
fix signed warning errors in unittests

A bunch of gtest assert statements fail due to signed warnings as
unadorned constants are treated as signed integers.  Mark them all
unsigned to avoid that.

One example (focus on the "[with ...]" blocks that show the types):
In file included from src/breakpad_googletest_includes.h:33:0,
                 from src/common/memory_unittest.cc:30:
src/testing/gtest/include/gtest/gtest.h: In instantiation of
'testing::AssertionResult testing::internal::CmpHelperEQ(const char*, const
char*, const T1&, const T2&) [with T1 = int; T2 = long unsigned int]':
src/testing/gtest/include/gtest/gtest.h:1524:23: required from 'static
testing::AssertionResult testing::internal::EqHelper<true>::Compare(const char*,
const char*, const T1&, const T2&, typename testing::internal::EnableIf<(!
testing::internal::is_pointer<T2>::value)>::type*) [with T1 = int; T2 = long
unsigned int; typename testing::internal::EnableIf<(!
testing::internal::is_pointer<T2>::value)>::type = void]'
src/common/memory_unittest.cc:41:246: required from here
src/testing/gtest/include/gtest/gtest.h:1448:16: error: comparison between
signed and unsigned integer expressions [-Werror=sign-compare]
   if (expected == actual) {
                ^
cc1plus: some warnings being treated as errors
Makefile:5180: recipe for target
'src/common/src_client_linux_linux_client_unittest_shlib-memory_unittest.o'
failed
make[2]: ***
[src/common/src_client_linux_linux_client_unittest_shlib-memory_unittest.o]
Error 1

R=ted.mielczarek@gmail.com

Committed:
https://chromium.googlesource.com/breakpad/breakpad/+/bad9e55ea52abd1bb759b80...
==========

[vapier, 2016-05-26 14:09:52]

Committed patchset #1 (id:1) manually as
bad9e55ea52abd1bb759b800d85aa8952e315af1 (presubmit successful).

[vapier, 2016-05-26 14:10:31]

i was building with gcc

i don't think Chromium configs will help here -- they don't build the unittests

[Ted Mielczarek, 2016-05-26 15:49:47]

On 2016/05/26 14:10:31, vapier wrote:
> i was building with gcc
> 
> i don't think Chromium configs will help here -- they don't build the
unittests

Right, I just meant "the set of CFLAGS/CXXFLAGS Chromium is building with". I
guess you're breaking because we have `-Werror=sign-compare` in CXXFLAGS in
Makefile.am, but why doesn't that break in Travis? Is it because the Travis GCC
is older?

[vapier, 2016-05-26 16:26:16]

perhaps.  the build errors i'm hitting aren't under Chromium ... these are on my
desktop building breakpad directly.  i'm using gcc-5.3 atm.