chrome/android/javatests/src/org/chromium/chrome/browser/printing/PrintingControllerTest.java - Issue 2013883002: ✈ Remove unnecessary flag and DocumentModeManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/printing/PrintingControllerTest.java

Issue 2013883002: ✈ Remove unnecessary flag and DocumentModeManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/partnercustomizations/PartnerHomepageIntegrationTest.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/tab/TabUmaTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/printing/PrintingControllerTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/printing/PrintingControllerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/printing/PrintingControllerTest.java

index 34aa02f55fca5d6ea398432838d800cd3330161d..b6d96c523726f3ef7383b1c6f0531c15ea064202 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/printing/PrintingControllerTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/printing/PrintingControllerTest.java

@@ -21,7 +21,6 @@ import org.chromium.base.test.util.Feature;

import org.chromium.base.test.util.TestFileUtil;

import org.chromium.base.test.util.UrlUtils;

import org.chromium.chrome.browser.ChromeActivity;

-import org.chromium.chrome.browser.ChromeSwitches;

import org.chromium.chrome.browser.tab.Tab;

import org.chromium.chrome.test.ChromeActivityTestCaseBase;

import org.chromium.chrome.test.util.browser.TabTitleObserver;

@@ -162,8 +161,7 @@ public class PrintingControllerTest extends ChromeActivityTestCaseBase<ChromeAct

* @SmallTest

* @Feature({"Printing"})

- @CommandLineFlags.Add(

- {ContentSwitches.DISABLE_POPUP_BLOCKING, ChromeSwitches.DISABLE_DOCUMENT_MODE})

+ @CommandLineFlags.Add(ContentSwitches.DISABLE_POPUP_BLOCKING)

@DisabledTest

public void testPrintClosedWindow() throws Throwable {

if (!ApiCompatibilityUtils.isPrintingSupported()) return;