Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassin.java

Issue 2013883002: ✈ Remove unnecessary flag and DocumentModeManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassin.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassin.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassin.java
index f3328c49529c66d67ec810cdaf48f0013d465d98..6d2eac17b76d847772d248e27e584d0ebd80db34 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassin.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassin.java
@@ -24,7 +24,6 @@ import org.chromium.chrome.browser.document.DocumentActivity;
import org.chromium.chrome.browser.document.DocumentUtils;
import org.chromium.chrome.browser.document.IncognitoDocumentActivity;
import org.chromium.chrome.browser.incognito.IncognitoNotificationManager;
-import org.chromium.chrome.browser.preferences.DocumentModeManager;
import org.chromium.chrome.browser.tab.Tab;
import org.chromium.chrome.browser.tabmodel.TabPersistentStore.TabModelMetadata;
import org.chromium.chrome.browser.tabmodel.document.ActivityDelegate;
@@ -105,6 +104,10 @@ public class DocumentModeAssassin {
/** Which TabModelSelectorImpl to copy files into during migration. */
private static final int TAB_MODEL_INDEX = 0;
+ /** SharedPreference values to determine whether user had document mode turned on. */
+ private static final String OPT_OUT_STATE = "opt_out_state";
+ private static final int OPTED_OUT_OF_DOCUMENT_MODE = 2;
+
/** Creates and holds the Singleton. */
private static class LazyHolder {
private static final DocumentModeAssassin INSTANCE = new DocumentModeAssassin();
@@ -364,8 +367,7 @@ public class DocumentModeAssassin {
// Record that the user has opted-out of document mode now that their data has been
// safely copied to the other directory.
Log.d(TAG, "Setting tabbed mode preference.");
- DocumentModeManager.getInstance(getContext()).setOptedOutState(
- DocumentModeManager.OPTED_OUT_OF_DOCUMENT_MODE);
+ clearOptedOutState();
TabSwitcherCallout.setIsTabSwitcherCalloutNecessary(getContext(), true);
// Remove all the {@link DocumentActivity} tasks from Android's Recents list. Users
@@ -545,4 +547,15 @@ public class DocumentModeAssassin {
protected File getTabbedDataDirectory() {
return TabPersistentStore.getOrCreateSelectorStateDirectory(TAB_MODEL_INDEX);
}
-}
+
+ /** @return True if the user is not in document mode. */
+ public static boolean isOptedOutOfDocumentMode() {
+ return ContextUtils.getAppSharedPreferences().getInt(
+ OPT_OUT_STATE, OPTED_OUT_OF_DOCUMENT_MODE) == OPTED_OUT_OF_DOCUMENT_MODE;
+ }
+
+ /** Clears the opt out preference so that user doesn't migrate again. */
+ private void clearOptedOutState() {
+ ContextUtils.getAppSharedPreferences().edit().remove(OPT_OUT_STATE).apply();
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698