Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2013863003: Add mojom structs for base::Time, base::TimeDelta and base::TimeTicks. (Closed)

Created:
4 years, 7 months ago by Sam McNally
Modified:
4 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add mojom structs for base::Time, base::TimeDelta and base::TimeTicks. Committed: https://crrev.com/6ae5d56453c79e8377e255f153ce8fe8cafa4d2d Cr-Commit-Position: refs/heads/master@{#396167}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -1 line) Patch
M mojo/common/common_custom_types.mojom View 1 chunk +9 lines, -0 lines 0 comments Download
M mojo/common/common_custom_types.typemap View 2 chunks +5 lines, -1 line 0 comments Download
M mojo/common/common_custom_types_unittest.cc View 2 chunks +73 lines, -0 lines 0 comments Download
M mojo/common/test_common_custom_types.mojom View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Sam McNally
4 years, 7 months ago (2016-05-26 08:30:52 UTC) #4
Ken Rockot(use gerrit already)
lgtm
4 years, 7 months ago (2016-05-26 12:13:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013863003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013863003/40001
4 years, 7 months ago (2016-05-26 12:49:23 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 7 months ago (2016-05-26 13:36:57 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 13:38:27 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6ae5d56453c79e8377e255f153ce8fe8cafa4d2d
Cr-Commit-Position: refs/heads/master@{#396167}

Powered by Google App Engine
This is Rietveld 408576698