Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: crosstest/crosstest.cfg

Issue 2013863002: Subzero: Crosstest test_arith properly tests i8/i16. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Revert i1 checks, which are already performed by PNaClTranslator Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | crosstest/test_arith.ll » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: crosstest/crosstest.cfg
diff --git a/crosstest/crosstest.cfg b/crosstest/crosstest.cfg
index a7d30b6de3d0786aaa5b05062fa50d0da5abde57..06c236de4290d2774cfe07d9bde834466f6fa8bb 100644
--- a/crosstest/crosstest.cfg
+++ b/crosstest/crosstest.cfg
@@ -9,7 +9,14 @@ flags: --sz=-fmem-intrin-opt
[test_arith]
driver: test_arith_main.cpp
-test: test_arith.cpp test_arith_frem.ll test_arith_sqrt.ll test_arith_fabs.ll
+# Note: test_arith.ll is auto-generated from test_arith.cpp - switch the "test:"
+# lines and then rename the resulting test_arith.*.pnacl.ll to test_arith.ll.
+# Then test_arith.ll is hand-modified so that i8 and i16 functions actually use
+# the i8/i16 form of the arithmetic instruction, to counteract C++'s integral
John 2016/05/25 17:26:28 It's not C++'s rule as the spec say types **can**
+# promotion rules.
+#
+#test: test_arith.cpp test_arith_frem.ll test_arith_sqrt.ll test_arith_fabs.ll
+test: test_arith.ll test_arith_frem.ll test_arith_sqrt.ll test_arith_fabs.ll
[test_bitmanip]
driver: test_bitmanip_main.cpp
« no previous file with comments | « no previous file | crosstest/test_arith.ll » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698