Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2013853003: MD Settings: remove lorem ipsums in Privacy settings, add real strings (Closed)

Created:
4 years, 7 months ago by Dan Beam
Modified:
4 years, 7 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: remove lorem ipsums in Privacy settings, add real strings R=dschuyler@chromium.org BUG=601536 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/24f9d2ed7b40e8c28cac804aa077f287dd75e0fe Cr-Commit-Position: refs/heads/master@{#396025}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
M chrome/app/settings_strings.grdp View 2 chunks +9 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/privacy_page/privacy_page.html View 1 chunk +2 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Dan Beam
screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=601536#c12
4 years, 7 months ago (2016-05-25 19:50:40 UTC) #2
dschuyler
lgtm
4 years, 7 months ago (2016-05-25 20:46:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013853003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013853003/1
4 years, 7 months ago (2016-05-25 20:51:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 22:56:46 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 22:59:20 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/24f9d2ed7b40e8c28cac804aa077f287dd75e0fe
Cr-Commit-Position: refs/heads/master@{#396025}

Powered by Google App Engine
This is Rietveld 408576698