Removing deprecated ios/web/user_metrics.cc and references to it.

Removing deprecated ios/web/user_metrics.cc and references to it.

BUG=604367
Committed: https://crrev.com/00027d1ada129ed0bb596150a9e22e5b7ed98ded
Cr-Commit-Position: refs/heads/master@{#402764}

[beaudoin, 2016-05-25 16:38:02]

The CQ bit was checked by beaudoin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-25 16:38:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2013853002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2013853002/40001

[beaudoin, 2016-05-25 16:39:41]

beaudoin@chromium.org changed reviewers:
+ sdefresne@chromium.org

[beaudoin, 2016-05-25 16:39:42]

sdefresne: PTAL. ios-specific follow-up a CL you reviewed, simply getting rid of
deprecated stuff. Original CL: https://codereview.chromium.org/1859213002/

[sdefresne, 2016-05-25 17:36:40]

On 2016/05/25 at 16:39:42, beaudoin wrote:
> sdefresne: PTAL. ios-specific follow-up a CL you reviewed, simply getting rid
of deprecated stuff. Original CL: https://codereview.chromium.org/1859213002/

I think it is still too early for that CL as I count 170+ occurrences of
web::RecordAction in iOS downstream repository.

[beaudoin, 2016-05-25 17:43:22]

On 2016/05/25 17:36:40, sdefresne wrote:
> On 2016/05/25 at 16:39:42, beaudoin wrote:
> > sdefresne: PTAL. ios-specific follow-up a CL you reviewed, simply getting
rid
> of deprecated stuff. Original CL: https://codereview.chromium.org/1859213002/
> 
> I think it is still too early for that CL as I count 170+ occurrences of
> web::RecordAction in iOS downstream repository.

Np. Let's put it on the ice for now. Should we have someone own the change in
the downstream repo?

[sdefresne, 2016-05-25 17:46:52]

On 2016/05/25 at 17:43:22, beaudoin wrote:
> On 2016/05/25 17:36:40, sdefresne wrote:
> > On 2016/05/25 at 16:39:42, beaudoin wrote:
> > > sdefresne: PTAL. ios-specific follow-up a CL you reviewed, simply getting
rid
> > of deprecated stuff. Original CL:
https://codereview.chromium.org/1859213002/
> > 
> > I think it is still too early for that CL as I count 170+ occurrences of
> > web::RecordAction in iOS downstream repository.
> 
> Np. Let's put it on the ice for now. Should we have someone own the change in
the downstream repo?

Probably, but I'm afraid this is going to be low priority for the iOS team. Can
you file a bug and leave it unassigned but with OS=ios? It should be triaged at
some point.

If you really want this to get fixed soon, maybe you can contribute the change
downstream too.

[beaudoin, 2016-05-25 17:51:29]

On 2016/05/25 17:46:52, sdefresne wrote:
> On 2016/05/25 at 17:43:22, beaudoin wrote:
> > On 2016/05/25 17:36:40, sdefresne wrote:
> > > On 2016/05/25 at 16:39:42, beaudoin wrote:
> > > > sdefresne: PTAL. ios-specific follow-up a CL you reviewed, simply
getting
> rid
> > > of deprecated stuff. Original CL:
> https://codereview.chromium.org/1859213002/
> > > 
> > > I think it is still too early for that CL as I count 170+ occurrences of
> > > web::RecordAction in iOS downstream repository.
> > 
> > Np. Let's put it on the ice for now. Should we have someone own the change
in
> the downstream repo?
> 
> Probably, but I'm afraid this is going to be low priority for the iOS team.
Can
> you file a bug and leave it unassigned but with OS=ios? It should be triaged
at
> some point.
> 
> If you really want this to get fixed soon, maybe you can contribute the change
> downstream too.

Oh, I don't really care that much. Was just doing the follow-up to my initial
patch.

[commit-bot: I haz the power, 2016-05-25 19:06:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-25 19:06:52]

Dry run: This issue passed the CQ dry run.

[commit-bot: I haz the power, 2016-05-25 19:07:11]

Dry run: None

[sdefresne, 2016-06-17 14:08:52]

Downstream uses of ios/web/user_metrics.h have been removed, so this should be
good to go now, thank you for waiting.

LGTM

[sdefresne, 2016-06-29 08:54:27]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2016-06-29 08:54:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 09:53:23]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-29 09:54:59]

Description was changed from

==========
Removing deprecated ios/web/user_metrics.cc and references to it.

BUG=604367
==========

to

==========
Removing deprecated ios/web/user_metrics.cc and references to it.

BUG=604367

Committed: https://crrev.com/00027d1ada129ed0bb596150a9e22e5b7ed98ded
Cr-Commit-Position: refs/heads/master@{#402764}
==========

[commit-bot: I haz the power, 2016-06-29 09:55:00]

Patchset 3 (id:??) landed as
https://crrev.com/00027d1ada129ed0bb596150a9e22e5b7ed98ded
Cr-Commit-Position: refs/heads/master@{#402764}