[DevTools] Handle valid urls with quotes inside them in SSP.

[DevTools] Handle valid urls with quotes inside them in SSP.

BUG=614267
Committed: https://crrev.com/433b281b1b4f5a22ab179e7135b6d98b33ee1bbe
Cr-Commit-Position: refs/heads/master@{#396076}

[dgozman, 2016-05-25 18:17:20]

dgozman@chromium.org changed reviewers:
+ lushnikov@chromium.org

[dgozman, 2016-05-25 18:17:21]

Take a look please.

[lushnikov, 2016-05-25 18:27:11]

lgtm

https://codereview.chromium.org/2013843003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
(right):

https://codereview.chromium.org/2013843003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:3110:
if (url.length >= 2 && (url[0] == "\"" && url[url.length - 1] == "\"") ||
(url[0] == "'" && url[url.length - 1] == "'"))
1. ===
2. You can use template strings to avoid quote escaping: `"`

How do you like the regex version of this? I think it might be a little bit
easier to read:

var isQuoted = /^'.*'$/.test(url) || /^".*"$/.test(url);
if (isQuoted) {
    ...
}

[dgozman, 2016-05-25 20:19:19]

https://codereview.chromium.org/2013843003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
(right):

https://codereview.chromium.org/2013843003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:3110:
if (url.length >= 2 && (url[0] == "\"" && url[url.length - 1] == "\"") ||
(url[0] == "'" && url[url.length - 1] == "'"))
On 2016/05/25 18:27:11, lushnikov wrote:
> 1. ===
> 2. You can use template strings to avoid quote escaping: `"`
> 
> How do you like the regex version of this? I think it might be a little bit
> easier to read:
> 
> var isQuoted = /^'.*'$/.test(url) || /^".*"$/.test(url);
> if (isQuoted) {
>     ...
> }
> 
> 

Done.

[dgozman, 2016-05-25 20:19:38]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-05-25 20:19:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/2013843003/#ps20001
(title: "review comment")

[commit-bot: I haz the power, 2016-05-25 20:20:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2013843003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2013843003/20001

[commit-bot: I haz the power, 2016-05-25 20:42:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-25 20:42:56]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dgozman, 2016-05-25 21:11:55]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-05-25 21:12:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2013843003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2013843003/20001

[commit-bot: I haz the power, 2016-05-25 22:42:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-25 22:42:57]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dgozman, 2016-05-25 23:08:43]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-05-25 23:08:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/2013843003/#ps40001
(title: "rebased tests")

[commit-bot: I haz the power, 2016-05-25 23:09:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2013843003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2013843003/40001

[commit-bot: I haz the power, 2016-05-26 01:17:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-26 01:24:14]

Description was changed from

==========
[DevTools] Handle valid urls with quotes inside them in SSP.

BUG=614267
==========

to

==========
[DevTools] Handle valid urls with quotes inside them in SSP.

BUG=614267

Committed: https://crrev.com/433b281b1b4f5a22ab179e7135b6d98b33ee1bbe
Cr-Commit-Position: refs/heads/master@{#396076}
==========

[commit-bot: I haz the power, 2016-05-26 01:24:16]

Patchset 3 (id:??) landed as
https://crrev.com/433b281b1b4f5a22ab179e7135b6d98b33ee1bbe
Cr-Commit-Position: refs/heads/master@{#396076}