Chromium Code Reviews

Issue 2013833002: ComputedStyle.h doesn't need CSSPrimitiveValue.h if adjustForAbsoluteZoom(int, float) isn't inline. (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
Reviewers:
eae
CC:
chromium-reviews, blink-reviews, blink-reviews-style_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ComputedStyle.h doesn't need CSSPrimitiveValue.h if adjustForAbsoluteZoom(int, float) isn't inline. BUG=614015 Committed: https://crrev.com/39cbd9dfb8617a77c8a9f3b77183925d0680f573 Cr-Commit-Position: refs/heads/master@{#395943}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+22 lines, -17 lines)
M third_party/WebKit/Source/core/style/ComputedStyle.h View 2 chunks +5 lines, -17 lines 0 comments
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 2 chunks +17 lines, -0 lines 0 comments

Messages

Total messages: 8 (3 generated)
mstensho (USE GERRIT)
@eae, what do you think? Doesn't seem performance-critical to me.
4 years, 7 months ago (2016-05-25 16:02:21 UTC) #2
eae
We don't call adjustForAbsoluteZoom nearly as much as we used to, this should be fairly ...
4 years, 7 months ago (2016-05-25 16:57:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013833002/1
4 years, 7 months ago (2016-05-25 17:45:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 18:44:50 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 18:46:01 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/39cbd9dfb8617a77c8a9f3b77183925d0680f573
Cr-Commit-Position: refs/heads/master@{#395943}

Powered by Google App Engine