Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Unified Diff: Source/bindings/v8/V8WindowShell.cpp

Issue 201383002: Use new is*Element() helper functions more in bindings/ code (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Minor clean up Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/V8GCController.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/V8WindowShell.cpp
diff --git a/Source/bindings/v8/V8WindowShell.cpp b/Source/bindings/v8/V8WindowShell.cpp
index fb0f3dfae23f518514c20d6254c0714cc65f3ef6..f5013a38d5aaebc4a30d2bb42f2323716c532727 100644
--- a/Source/bindings/v8/V8WindowShell.cpp
+++ b/Source/bindings/v8/V8WindowShell.cpp
@@ -425,8 +425,9 @@ static v8::Handle<v8::Value> getNamedProperty(HTMLDocument* htmlDocument, const
if (items->hasExactlyOneItem()) {
Element* element = items->item(0);
+ ASSERT(element);
LocalFrame* frame = 0;
- if (element->hasTagName(HTMLNames::iframeTag) && (frame = toHTMLIFrameElement(element)->contentFrame()))
+ if (isHTMLIFrameElement(*element) && (frame = toHTMLIFrameElement(*element).contentFrame()))
return toV8(frame->domWindow(), creationContext, isolate);
return toV8(element, creationContext, isolate);
}
« no previous file with comments | « Source/bindings/v8/V8GCController.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698