Issue 201383002: Use new is*Element() helper functions more in bindings/ code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 201383002: Use new is*Element() helper functions more in bindings/ code (Closed)

Created:
6 years, 9 months ago by Inactive

Modified:
6 years, 9 months ago

Reviewers:
haraken, adamk

CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, kouhei+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Use new is*Element() helper functions more in bindings/ code Use new is*Element() helpers more in bindings/ code. This makes the code clearer and simpler. R=haraken, adamk BUG=346095 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169319

Patch Set 1 #

Patch Set 2 : Minor clean up #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -5 lines)			Patch
	M	Source/bindings/v8/V8GCController.cpp	View		3 chunks	+5 lines, -4 lines	0 comments	Download
	M	Source/bindings/v8/V8WindowShell.cpp	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/201383002/20001

6 years, 9 months ago (2014-03-17 01:14:40 UTC) #4

Message was sent while issue was closed.

Change committed as 169319

Expand Messages | Collapse Messages