Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Unified Diff: tests/compiler/dart2js/serialization/analysis_test.dart

Issue 2013763002: Add names and support for preserialized data to serialization tests (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Updated cf. comments. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/serialization/analysis_test.dart
diff --git a/tests/compiler/dart2js/serialization/analysis_test.dart b/tests/compiler/dart2js/serialization/analysis_test.dart
index 42c1f5fc6c40de64c3e74ae7faf3182951413f4e..152972bd7cc726e2ce63ee9af167e77fff6ee8e1 100644
--- a/tests/compiler/dart2js/serialization/analysis_test.dart
+++ b/tests/compiler/dart2js/serialization/analysis_test.dart
@@ -21,29 +21,32 @@ main(List<String> args) {
await serializeDartCore(arguments: arguments);
if (arguments.filename != null) {
Uri entryPoint = Uri.base.resolve(nativeToUriPath(arguments.filename));
- await analyze(serializedData, entryPoint, null);
+ await analyze(entryPoint,
+ resolutionInputs: serializedData.toUris(),
+ sourceFiles: serializedData.toMemorySourceFiles());
} else {
- Uri entryPoint = Uri.parse('memory:main.dart');
- await arguments.forEachTest(TESTS, (int index, Test test) async {
- await analyze(serializedData, entryPoint, test);
- });
+ await arguments.forEachTest(serializedData, TESTS, analyze);
}
});
}
-Future analyze(SerializedData serializedData, Uri entryPoint, Test test,
- {int index}) async {
- String testDescription =
- test != null ? test.sourceFiles[entryPoint.path] : '${entryPoint}';
+Future analyze(
+ Uri entryPoint,
+ {Map<String, String> sourceFiles: const <String, String>{},
+ List<Uri> resolutionInputs,
+ int index,
+ Test test,
+ bool verbose: false}) async {
+ String testDescription = test != null ? test.name : '${entryPoint}';
+ String id = index != null ? '$index: ' : '';
print('------------------------------------------------------------------');
- print('analyze ${index != null ? '$index:' :''}${testDescription}');
+ print('analyze ${id}${testDescription}');
print('------------------------------------------------------------------');
DiagnosticCollector diagnosticCollector = new DiagnosticCollector();
await runCompiler(
entryPoint: entryPoint,
- resolutionInputs: serializedData.toUris(),
- memorySourceFiles: serializedData.toMemorySourceFiles(
- test != null ? test.sourceFiles : null),
+ resolutionInputs: resolutionInputs,
+ memorySourceFiles: sourceFiles,
options: [Flags.analyzeOnly],
diagnosticHandler: diagnosticCollector);
if (test != null) {
« no previous file with comments | « pkg/compiler/lib/src/serialization/system.dart ('k') | tests/compiler/dart2js/serialization/compilation_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698