Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2013763002: Add names and support for preserialized data to serialization tests (Closed)

Created:
4 years, 7 months ago by Johnni Winther
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add names and support for preserialized data to serialization tests R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/326af10bc8a3197d157ac8727077a942c27b2015

Patch Set 1 #

Patch Set 2 : Dartfmt #

Total comments: 2

Patch Set 3 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -107 lines) Patch
M pkg/compiler/lib/src/dart_types.dart View 1 4 chunks +11 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 2 chunks +6 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/serialization/system.dart View 1 3 chunks +10 lines, -8 lines 0 comments Download
M tests/compiler/dart2js/serialization/analysis_test.dart View 1 2 1 chunk +16 lines, -13 lines 0 comments Download
M tests/compiler/dart2js/serialization/compilation_test.dart View 1 2 1 chunk +17 lines, -14 lines 0 comments Download
M tests/compiler/dart2js/serialization/helper.dart View 3 chunks +69 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/serialization/model_test.dart View 1 2 2 chunks +16 lines, -18 lines 0 comments Download
M tests/compiler/dart2js/serialization/resolved_ast_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/serialization/test_data.dart View 21 chunks +82 lines, -33 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years, 7 months ago (2016-05-25 10:06:18 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2013763002/diff/20001/tests/compiler/dart2js/serialization/model_test.dart File tests/compiler/dart2js/serialization/model_test.dart (right): https://codereview.chromium.org/2013763002/diff/20001/tests/compiler/dart2js/serialization/model_test.dart#newcode52 tests/compiler/dart2js/serialization/model_test.dart:52: print('compile normal ${index != null ? '$index: ' ...
4 years, 7 months ago (2016-05-25 17:24:32 UTC) #3
Johnni Winther
Committed patchset #3 (id:40001) manually as 326af10bc8a3197d157ac8727077a942c27b2015 (presubmit successful).
4 years, 7 months ago (2016-05-26 07:36:48 UTC) #5
Johnni Winther
4 years, 7 months ago (2016-05-26 10:56:37 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/2013763002/diff/20001/tests/compiler/dart2js/...
File tests/compiler/dart2js/serialization/model_test.dart (right):

https://codereview.chromium.org/2013763002/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/serialization/model_test.dart:52: print('compile normal
${index != null ? '$index: ' :''}${testDescription}');
On 2016/05/25 17:24:32, Siggi Cherem (dart-lang) wrote:
> maybe define
> 
> String id = index ?? ''; (or index == null ? '' : ' $index')
> 
> and use it here and below...

Done.

Powered by Google App Engine
This is Rietveld 408576698