Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 2013723004: Fix a couple of pointer DCHECKs (Closed)

Created:
4 years, 7 months ago by Wez
Modified:
4 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a couple of pointer DCHECKs. These don't work when DCHECK is switched to a more CHECK-like impl, since there is no operator<<() for the relevant pointer type. BUG=596231 Committed: https://crrev.com/bd4ffd8f5f7269b818d544cc55ff059be8095d49 Cr-Commit-Position: refs/heads/master@{#396038}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/debug/profiler.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Wez
Teeny weeny cleanup CL; PTAL
4 years, 7 months ago (2016-05-25 21:43:19 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013723004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013723004/1
4 years, 7 months ago (2016-05-25 21:44:49 UTC) #4
Mark Mentovai
LGTM
4 years, 7 months ago (2016-05-25 21:52:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013723004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013723004/1
4 years, 7 months ago (2016-05-25 21:54:47 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 23:33:47 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 23:35:38 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd4ffd8f5f7269b818d544cc55ff059be8095d49
Cr-Commit-Position: refs/heads/master@{#396038}

Powered by Google App Engine
This is Rietveld 408576698