third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp - Issue 2013723002: Consider ClipPathDisplayItems for GPU veto.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp

Issue 2013723002: Consider ClipPathDisplayItems for GPU veto. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix unit test asserts Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp ('k') | third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp b/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp

index 6b6db13c7262e445db7214c0a3864ac7277f0eb7..9816b91a2278b54b83212b22b4f617c8d5627161 100644

--- a/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp

+++ b/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp

@@ -312,8 +312,9 @@ void PaintController::commitNewDisplayItems(const LayoutSize& offsetFromLayoutOb

for (const auto& item : m_newDisplayItemList) {

m_newDisplayItemList.appendVisualRect(visualRectForDisplayItem(item, offsetFromLayoutObject));

- if (item.isDrawing())

- gpuAnalyzer.analyze(static_cast<const DrawingDisplayItem&>(item).picture());

+ // No reason to continue the analysis once we have a veto.

+ if (gpuAnalyzer.suitableForGpuRasterization())

+ item.analyzeForGpuRasterization(gpuAnalyzer);

}

m_currentPaintArtifact = PaintArtifact(std::move(m_newDisplayItemList), m_newPaintChunks.releasePaintChunks(), gpuAnalyzer.suitableForGpuRasterization());

m_newDisplayItemList = DisplayItemList(kInitialDisplayItemListCapacityBytes);