Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1929)

Unified Diff: src/snapshot/snapshot.h

Issue 2013713003: [heap] Switch to 500k pages (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix compilation on Windows Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/snapshot/snapshot.h
diff --git a/src/snapshot/snapshot.h b/src/snapshot/snapshot.h
index a541592feeea8061670ce21e1964a2244f49c7d0..937edfb8e3056339263417953530a5e2524f8f41 100644
--- a/src/snapshot/snapshot.h
+++ b/src/snapshot/snapshot.h
@@ -67,9 +67,6 @@ class Snapshot : public AllStatic {
static bool EmbedsScript(Isolate* isolate);
- static uint32_t SizeOfFirstPage(Isolate* isolate, AllocationSpace space);
-
-
// To be implemented by the snapshot source.
static const v8::StartupData* DefaultSnapshotBlob();
@@ -88,7 +85,6 @@ class Snapshot : public AllStatic {
int index);
// Snapshot blob layout:
- // [0 - 5] pre-calculated first page sizes for paged spaces
// [6] number of contexts N
Yang 2016/08/09 13:26:29 Please update the indices here.
Michael Lippautz 2016/08/09 13:55:32 Done.
// [7] offset to context 0
// [8] offset to context 1
@@ -100,9 +96,7 @@ class Snapshot : public AllStatic {
static const int kNumPagedSpaces = LAST_PAGED_SPACE - FIRST_PAGED_SPACE + 1;
Yang 2016/08/09 13:26:29 Do we still need this constant?
Michael Lippautz 2016/08/09 13:55:32 Removed.
- static const int kFirstPageSizesOffset = 0;
- static const int kNumberOfContextsOffset =
- kFirstPageSizesOffset + kNumPagedSpaces * kInt32Size;
+ static const int kNumberOfContextsOffset = 0;
static const int kFirstContextOffsetOffset =
kNumberOfContextsOffset + kInt32Size;
« no previous file with comments | « src/objects.h ('k') | src/snapshot/snapshot-common.cc » ('j') | src/snapshot/snapshot-common.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698