Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2013713002: Revert of Finish eliminating PlatformWindowMus (Closed)

Created:
4 years, 7 months ago by sadrul
Modified:
4 years, 7 months ago
Reviewers:
nyquist, sky, Mark Dittmer
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, sadrul, sriramsr+watch-blimp_chromium.org, tfarina, maniscalco+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, kalyank, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org, Fady Samuel
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Finish eliminating PlatformWindowMus (patchset #7 id:120001 of https://codereview.chromium.org/1999083002/ ) Reason for revert: This breaks window-frames in mash Original issue's description: > Finish eliminating PlatformWindowMus > > R=sadrul@chromium.org > BUG=609555 > > Committed: https://crrev.com/2b2114f0e297428fbe15ef169d05f9bbf9749a8e > Cr-Commit-Position: refs/heads/master@{#395694} TBR=nyquist@chromium.org,sky@chromium.org,markdittmer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=609555 Committed: https://crrev.com/70394d0c09c10d2ca3f8f82fa9a83bc84478ed6f Cr-Commit-Position: refs/heads/master@{#395779}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+276 lines, -82 lines) Patch
M ash/host/ash_window_tree_host_unified.cc View 2 chunks +1 line, -3 lines 0 comments Download
M ash/mus/sysui_application.cc View 1 chunk +1 line, -2 lines 0 comments Download
M blimp/engine/app/ui/blimp_window_tree_host.cc View 1 chunk +1 line, -3 lines 0 comments Download
M ui/platform_window/stub/stub_window.h View 2 chunks +1 line, -3 lines 0 comments Download
M ui/platform_window/stub/stub_window.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M ui/views/mus/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M ui/views/mus/native_widget_mus.cc View 6 chunks +17 lines, -17 lines 0 comments Download
M ui/views/mus/native_widget_mus_unittest.cc View 1 chunk +52 lines, -0 lines 0 comments Download
A ui/views/mus/platform_window_mus.h View 1 chunk +80 lines, -0 lines 0 comments Download
A ui/views/mus/platform_window_mus.cc View 1 chunk +109 lines, -0 lines 0 comments Download
M ui/views/mus/window_tree_host_mus.h View 3 chunks +2 lines, -12 lines 0 comments Download
M ui/views/mus/window_tree_host_mus.cc View 3 chunks +8 lines, -36 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
sadrul
Created Revert of Finish eliminating PlatformWindowMus
4 years, 7 months ago (2016-05-25 02:12:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013713002/1
4 years, 7 months ago (2016-05-25 02:12:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 02:13:25 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 02:15:07 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/70394d0c09c10d2ca3f8f82fa9a83bc84478ed6f
Cr-Commit-Position: refs/heads/master@{#395779}

Powered by Google App Engine
This is Rietveld 408576698