Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: third_party/WebKit/LayoutTests/fast/table/change-tbody-border-width.html

Issue 2013693002: [css-tables] Set table and cell widths dirty when section border changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: handle case where row is null Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/table/change-tbody-border-width.html
diff --git a/third_party/WebKit/LayoutTests/fast/table/change-tbody-border-width.html b/third_party/WebKit/LayoutTests/fast/table/change-tbody-border-width.html
new file mode 100644
index 0000000000000000000000000000000000000000..6760bc588672080ccd44def486f9d5f0410e123a
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/fast/table/change-tbody-border-width.html
@@ -0,0 +1,30 @@
+<!doctype html>
+<style>
+ td {
+ width: 50px;
+ height: 50px;
+ padding: 0px;
+ }
+</style>
+<script src="../../resources/check-layout.js"></script>
+<script src="../../resources/run-after-layout-and-paint.js"></script>
+<script type="text/javascript">
+ function shrinkSectionBorder() {
+ document.getElementById("section").style.borderWidth = "4px";
+ checkLayout("div");
+ }
+ runAfterLayoutAndPaint(shrinkSectionBorder, true);
+</script>
+<p>Changing a collapsed border's width should change the width of the table and the width of a shrink-to-fit containing block.</p>
+<p>There should be a square with a 4px inner blue border and a 1px outer black border.</p>
+<p>Firefox 50.0a1 (nightly 2016-07-07) fails this, so it should probably be upstreamed, except it uses chrome-specific `runAfterLayoutAndPaint`.</p>
+<p>The table cell has rowspan=2 because we almost didn't cover the case where a cell's rowspan exceeded the declared rows.</p>
+<div style="float:left; border: 1px solid black" data-expected-width=60>
+ <table style="border-collapse:collapse" data-expected-width=58 data-expected-height=58>
+ <tbody style="border:18px solid lightblue" id="section">
+ <tr>
+ <td rowspan=2></td>
+ </tr>
+ </tbody>
+ </table>
+</div>

Powered by Google App Engine
This is Rietveld 408576698