Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1295)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTableRow.cpp

Issue 2013693002: [css-tables] Set table and cell widths dirty when section border changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add optional param and remove new layout test Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutTableRow.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp b/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp
index c63007719465c5a0a5efd43a6d44b3429359d571..ada39b45113f3505d58634876695db89bde3e241 100644
--- a/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp
@@ -53,14 +53,6 @@ void LayoutTableRow::willBeRemovedFromTree()
section()->setNeedsCellRecalc();
}
-static bool borderWidthChanged(const ComputedStyle* oldStyle, const ComputedStyle* newStyle)
-{
- return oldStyle->borderLeftWidth() != newStyle->borderLeftWidth()
- || oldStyle->borderTopWidth() != newStyle->borderTopWidth()
- || oldStyle->borderRightWidth() != newStyle->borderRightWidth()
- || oldStyle->borderBottomWidth() != newStyle->borderBottomWidth();
-}
-
void LayoutTableRow::styleDidChange(StyleDifference diff, const ComputedStyle* oldStyle)
{
ASSERT(style()->display() == TABLE_ROW);
@@ -84,6 +76,7 @@ void LayoutTableRow::styleDidChange(StyleDifference diff, const ComputedStyle* o
for (LayoutBox* childBox = firstChildBox(); childBox; childBox = childBox->nextSiblingBox()) {
if (!childBox->isTableCell())
continue;
+ // TODO(dgrogan) Add a layout test showing that setChildNeedsLayout is needed instead of setNeedsLayout.
dgrogan 2016/07/01 20:02:26 I failed to generate one :( But this patch can lan
eae 2016/07/01 22:20:25 Sadness. Let's try to create one together at some
childBox->setChildNeedsLayout();
childBox->setPreferredLogicalWidthsDirty(MarkOnlyThis);
}

Powered by Google App Engine
This is Rietveld 408576698