Chromium Code Reviews| Index: third_party/WebKit/Source/core/layout/LayoutTableRow.cpp |
| diff --git a/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp b/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp |
| index c63007719465c5a0a5efd43a6d44b3429359d571..b7648e7ce1815d84f1cfb3d0f97d29506ff2e1d7 100644 |
| --- a/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp |
| +++ b/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp |
| @@ -53,14 +53,6 @@ void LayoutTableRow::willBeRemovedFromTree() |
| section()->setNeedsCellRecalc(); |
| } |
| -static bool borderWidthChanged(const ComputedStyle* oldStyle, const ComputedStyle* newStyle) |
| -{ |
| - return oldStyle->borderLeftWidth() != newStyle->borderLeftWidth() |
| - || oldStyle->borderTopWidth() != newStyle->borderTopWidth() |
| - || oldStyle->borderRightWidth() != newStyle->borderRightWidth() |
| - || oldStyle->borderBottomWidth() != newStyle->borderBottomWidth(); |
| -} |
| - |
| void LayoutTableRow::styleDidChange(StyleDifference diff, const ComputedStyle* oldStyle) |
| { |
| ASSERT(style()->display() == TABLE_ROW); |
| @@ -84,6 +76,10 @@ void LayoutTableRow::styleDidChange(StyleDifference diff, const ComputedStyle* o |
| for (LayoutBox* childBox = firstChildBox(); childBox; childBox = childBox->nextSiblingBox()) { |
| if (!childBox->isTableCell()) |
| continue; |
| + // TODO(dgrogan) Changing this to setNeedsLayout doesn't cause |
|
dgrogan
2016/06/10 22:51:11
eae@, I'm getting diminishing returns trying to un
|
| + // any layout tests to fail. Isn't setChildNeedsLayout more |
| + // expensive? If setNeedsLayout is insufficient, add a layout |
| + // test demonstrating so. |
| childBox->setChildNeedsLayout(); |
| childBox->setPreferredLogicalWidthsDirty(MarkOnlyThis); |
| } |