third_party/WebKit/Source/core/layout/LayoutTableRow.cpp - Issue 2013693002: [css-tables] Set table and cell widths dirty when section border changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTableRow.cpp

Issue 2013693002: [css-tables] Set table and cell widths dirty when section border changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/table/border-collapsing/cached-change-tbody-border-width-expected.txt ('k') | third_party/WebKit/Source/core/layout/LayoutTableSection.cpp » ('j') | third_party/WebKit/Source/core/layout/LayoutTableSection.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutTableRow.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp b/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp

index cc800331100f484e9f021dd638b8e549bd1c5241..ca0ccfc78959f63d941bcc48d45a440b2925eb43 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp

@@ -77,6 +77,7 @@ void LayoutTableRow::styleDidChange(StyleDifference diff, const ComputedStyle* o

if (table && !table->selfNeedsLayout() && !table->normalChildNeedsLayout() && oldStyle && oldStyle->border() != style()->border())

table->invalidateCollapsedBorders();

+ // TODO(dgrogan): Do we need to setPreferredLogicalWidthsDirty even when !diff.needsFullLayout()?

mstensho (USE GERRIT) 2016/05/25 12:18:28 No? :) See my other comment.

if (table && oldStyle && diff.needsFullLayout() && needsLayout() && table->collapseBorders() && borderWidthChanged(oldStyle, style())) {

// If the border width changes on a row, we need to make sure the cells in the row know to lay out again.

// This only happens when borders are collapsed, since they end up affecting the border sides of the cell