[css-tables] Set table and cell widths dirty when section border changes

third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

 /*
  * Copyright (C) 1997 Martin Jones (mjones@kde.org)
  *           (C) 1997 Torben Weis (weis@kde.org)
  *           (C) 1998 Waldo Bastian (bastian@kde.org)
  *           (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009, 2010, 2013 Apple Inc. All rights reserved.
  * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 107 matching lines @@
 
 void LayoutTableSection::styleDidChange(StyleDifference diff, const ComputedStyle* oldStyle)
 {
     LayoutTableBoxComponent::styleDidChange(diff, oldStyle);
     propagateStyleToAnonymousChildren();
 
     // If border was changed, notify table.
     LayoutTable* table = this->table();
     if (table && !table->selfNeedsLayout() && !table->normalChildNeedsLayout() && oldStyle && oldStyle->border() != style()->border())
         table->invalidateCollapsedBorders();
+
+    if (table && oldStyle && diff.needsFullLayout() && needsLayout() && table->collapseBorders() && borderWidthChanged(oldStyle, style())) {
+        // TODO(dgrogan): Do we need to call cell->setChildNeedsLayout() like LayoutTableRow::styleDidChange does?

[dgrogan, 2016/05/27 00:23:53]

I'll dig into this tomorrow if you don't know off the top of your head.

[mstensho (USE GERRIT), 2016/05/27 08:36:33]

My guess: yes, you need to do that. I'm not aware of any mechanism that detects
preferred width changes and marks for layout based on that. But please dig. :)
I'm not super-familiar with the preferred widths calculation machinery.

+        markAllCellWidthsDirty();
+    }
 }
 
 void LayoutTableSection::willBeRemovedFromTree()
 {
     LayoutTableBoxComponent::willBeRemovedFromTree();
 
     // Preventively invalidate our cells as we may be re-inserted into
     // a new table which would require us to rebuild our structure.
     setNeedsCellRecalc();
 }
@@ skipping 1060 matching lines @@
         if (rowChildrenOverflowChanged)
             rowLayouter->computeOverflow();
         childrenOverflowChanged |= rowChildrenOverflowChanged;
     }
     // TODO(crbug.com/604136): Add visual overflow from rows too.
     if (childrenOverflowChanged)
         computeOverflowFromCells(totalRows, numEffCols);
     return childrenOverflowChanged;
 }
 
+void LayoutTableSection::markAllCellWidthsDirty()
+{
+    for (unsigned i = 0; i < numRows(); i++) {
+        LayoutTableRow* row = rowLayoutObjectAt(i);
+        if (!row)
+            continue;
+        for (LayoutTableCell* cell = row->firstCell(); cell; cell = cell->nextCell())
+            cell->setPreferredLogicalWidthsDirty();
+    }
+}
+
 int LayoutTableSection::calcBlockDirectionOuterBorder(BlockBorderSide side) const
 {
     unsigned totalCols = table()->numEffectiveColumns();
     if (!m_grid.size() || !totalCols)
         return 0;
 
     int borderWidth = 0;
 
     const BorderValue& sb = side == BorderBefore ? style()->borderBefore() : style()->borderAfter();
     if (sb.style() == BorderStyleHidden)
@@ skipping 446 matching lines @@
     // FIXME: The table's direction should determine our row's direction, not the section's (see bug 96691).
     if (!style()->isLeftToRightDirection())
         cellLocation.setX(LayoutUnit(table()->effectiveColumnPositions()[table()->numEffectiveColumns()] - table()->effectiveColumnPositions()[table()->absoluteColumnToEffectiveColumn(cell->absoluteColumnIndex() + cell->colSpan())] + horizontalBorderSpacing));
     else
         cellLocation.setX(LayoutUnit(table()->effectiveColumnPositions()[effectiveColumn] + horizontalBorderSpacing));
 
     cell->setLogicalLocation(cellLocation);
 }
 
 } // namespace blink