[css-tables] Set table and cell widths dirty when section border changes

third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

 /*
  * Copyright (C) 1997 Martin Jones (mjones@kde.org)
  *           (C) 1997 Torben Weis (weis@kde.org)
  *           (C) 1998 Waldo Bastian (bastian@kde.org)
  *           (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009, 2010, 2013 Apple Inc. All rights reserved.
  * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 108 matching lines @@
 
 void LayoutTableSection::styleDidChange(StyleDifference diff, const ComputedStyle* oldStyle)
 {
     LayoutTableBoxComponent::styleDidChange(diff, oldStyle);
     propagateStyleToAnonymousChildren();
 
     // If border was changed, notify table.
     LayoutTable* table = this->table();
     if (table && !table->selfNeedsLayout() && !table->normalChildNeedsLayout() && oldStyle && oldStyle->border() != style()->border())
         table->invalidateCollapsedBorders();
+
+    if (table && oldStyle && diff.needsFullLayout() && needsLayout() && table->collapseBorders() && oldStyle->border() != style()->border()) {
+        markAllCellsWidthsDirtyAndOrNeedsLayout(true /*markNeedsLayout*/);

[Xianzhu, 2016/07/07 23:13:30]

This is a good example that we prefer enum to bool as a parameter: the meaning
at call site would be clear without additional comments.

+    }
 }
 
 void LayoutTableSection::willBeRemovedFromTree()
 {
     LayoutTableBoxComponent::willBeRemovedFromTree();
 
     // Preventively invalidate our cells as we may be re-inserted into
     // a new table which would require us to rebuild our structure.
     setNeedsCellRecalc();
 }
@@ skipping 1075 matching lines @@
         if (rowChildrenOverflowChanged)
             rowLayouter->computeOverflow();
         childrenOverflowChanged |= rowChildrenOverflowChanged;
     }
     // TODO(crbug.com/604136): Add visual overflow from rows too.
     if (childrenOverflowChanged)
         computeOverflowFromCells(totalRows, numEffCols);
     return childrenOverflowChanged;
 }
 
+void LayoutTableSection::markAllCellsWidthsDirtyAndOrNeedsLayout(bool markNeedsLayout)

[Xianzhu, 2016/07/07 23:13:30]

Please change the parameter to an enum (or you can keep the bool if you would
like to do the following soon).

In the future you can consider to add

template <Function> forEachCell(Function f) {
  ...
    f(*cell);
  ...
}

in LayoutTableSection, and the call site at line 131 would be:
    forEachCell([](LayoutTableCell& cell) {
        cell.setPreferredLogicalWidthsDirty();
        cell.setChildNeedsLayout();
    });

+{
+    for (unsigned i = 0; i < numRows(); i++) {
+        LayoutTableRow* row = rowLayoutObjectAt(i);
+        // CHECK instead of DCHECK to see if this can be triggered in the wild.
+        // TODO(dgrogan): Change to DCHECK after m54 hits stable.
+        CHECK(row);
+        for (LayoutTableCell* cell = row->firstCell(); cell; cell = cell->nextCell()) {
+            cell->setPreferredLogicalWidthsDirty();
+            if (markNeedsLayout)
+                cell->setChildNeedsLayout();
+        }
+    }
+}
+
 int LayoutTableSection::calcBlockDirectionOuterBorder(BlockBorderSide side) const
 {
     unsigned totalCols = table()->numEffectiveColumns();
     if (!m_grid.size() || !totalCols)
         return 0;
 
     int borderWidth = 0;
 
     const BorderValue& sb = side == BorderBefore ? style()->borderBefore() : style()->borderAfter();
     if (sb.style() == BorderStyleHidden)
@@ skipping 476 matching lines @@
     // Repeating table headers are painted once per fragmentation page/column. This does not go through the regular fragmentation machinery,
     // so we need special code to expand the invalidation rect to contain all positions of the header in all columns.
     // Note that this is in flow thread coordinates, not visual coordinates. The enclosing LayoutFlowThread will convert to visual coordinates.
     if (table()->header() == this && hasRepeatingHeaderGroup())
         rect.setHeight(table()->logicalHeight());
     return LayoutTableBoxComponent::mapToVisualRectInAncestorSpace(ancestor, rect, flags);
 }
 
 
 } // namespace blink