[css-tables] Set table and cell widths dirty when section border changes

third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/layout/LayoutTableBoxComponent.h"
 
 #include "core/style/ComputedStyle.h"
 
 namespace blink {
 
 void LayoutTableBoxComponent::styleDidChange(StyleDifference diff, const ComputedStyle* oldStyle)
 {
     LayoutBox::styleDidChange(diff, oldStyle);
 
     if (parent() && oldStyle) {
         if (resolveColor(*oldStyle, CSSPropertyBackgroundColor) != resolveColor(CSSPropertyBackgroundColor)
             || oldStyle->backgroundLayers() != styleRef().backgroundLayers())
             m_backgroundChangedSinceLastPaintInvalidation = true;
     }
 }
 
 void LayoutTableBoxComponent::imageChanged(WrappedImagePtr, const IntRect*)
 {
     setShouldDoFullPaintInvalidation();
     m_backgroundChangedSinceLastPaintInvalidation = true;
 }
 
+bool LayoutTableBoxComponent::borderWidthChanged(const ComputedStyle* oldStyle, const ComputedStyle* newStyle)
+{
+    return oldStyle->borderLeftWidth() != newStyle->borderLeftWidth()

[eae, 2016/07/01 22:20:25]

"return oldStyle->border() != newStyle->border()" will compare the BorderData
objects. It will return true if the style changes in addition to the width but
triggering layout in that case doesn't seem too bad. Especially not if it
simplifies the logic.

Another option would be to add a sizeEquals method to BorderData and using that.

return return oldStyle->border().sizeEquals(newStyle->border());

[dgrogan, 2016/07/06 23:10:29]

I like this option... keep the logic about borders in the BorderData class.

+        || oldStyle->borderTopWidth() != newStyle->borderTopWidth()
+        || oldStyle->borderRightWidth() != newStyle->borderRightWidth()
+        || oldStyle->borderBottomWidth() != newStyle->borderBottomWidth();
+}
+
 } // namespace blink