Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 2013683004: Use dcheck_always_on for all Release GPU bots. (Closed)

Created:
4 years, 7 months ago by Jamie Madill
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use dcheck_always_on for GPU FYI Release trybots. This bot config was using release_bot instead of release_trybot. This will enable asserts in release code for these configs. BUG=614725 R=kbr@chromium.org,thakis@chromium.org Committed: https://crrev.com/de78a4363a52721a1a6e96d0eb71a7fbc1a52662 Cr-Commit-Position: refs/heads/master@{#396015}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated with Nico's feedback #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/mb/mb_config.pyl View 1 1 chunk +1 line, -1 line 3 comments Download

Messages

Total messages: 12 (3 generated)
Jamie Madill
PTAL Ken if you think this change is correct. Added Nico to verify my CL ...
4 years, 7 months ago (2016-05-25 16:56:23 UTC) #1
Nico
https://codereview.chromium.org/2013683004/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2013683004/diff/1/tools/mb/mb_config.pyl#newcode2199 tools/mb/mb_config.pyl:2199: 'mixins': ['release_bot_minimal_symbols', 'dcheck_always_on'], release_trybot already has dcheck_always_on as you ...
4 years, 7 months ago (2016-05-25 16:57:54 UTC) #2
Jamie Madill
On 2016/05/25 16:57:54, Nico wrote: > https://codereview.chromium.org/2013683004/diff/1/tools/mb/mb_config.pyl > File tools/mb/mb_config.pyl (right): > > https://codereview.chromium.org/2013683004/diff/1/tools/mb/mb_config.pyl#newcode2199 > ...
4 years, 7 months ago (2016-05-25 17:59:21 UTC) #4
Nico
lgtm if the answer below is "yes" https://codereview.chromium.org/2013683004/diff/20001/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2013683004/diff/20001/tools/mb/mb_config.pyl#newcode256 tools/mb/mb_config.pyl:256: 'GPU Linux ...
4 years, 7 months ago (2016-05-25 18:04:55 UTC) #5
Jamie Madill
https://codereview.chromium.org/2013683004/diff/20001/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2013683004/diff/20001/tools/mb/mb_config.pyl#newcode256 tools/mb/mb_config.pyl:256: 'GPU Linux Builder': 'swarming_gpu_fyi_tests_gn_release_trybot', On 2016/05/25 18:04:55, Nico wrote: ...
4 years, 7 months ago (2016-05-25 18:13:26 UTC) #6
Ken Russell (switch to Gerrit)
lgtm https://codereview.chromium.org/2013683004/diff/20001/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2013683004/diff/20001/tools/mb/mb_config.pyl#newcode256 tools/mb/mb_config.pyl:256: 'GPU Linux Builder': 'swarming_gpu_fyi_tests_gn_release_trybot', On 2016/05/25 18:13:26, Jamie ...
4 years, 7 months ago (2016-05-25 20:23:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013683004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013683004/20001
4 years, 7 months ago (2016-05-25 20:37:04 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-25 22:43:44 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 22:45:53 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/de78a4363a52721a1a6e96d0eb71a7fbc1a52662
Cr-Commit-Position: refs/heads/master@{#396015}

Powered by Google App Engine
This is Rietveld 408576698