Use dcheck_always_on for all Release GPU bots.

Use dcheck_always_on for GPU FYI Release trybots.

This bot config was using release_bot instead of release_trybot. This
will enable asserts in release code for these configs.

BUG=614725
R=kbr@chromium.org,thakis@chromium.org

Committed: https://crrev.com/de78a4363a52721a1a6e96d0eb71a7fbc1a52662
Cr-Commit-Position: refs/heads/master@{#396015}

[Jamie Madill, 2016-05-25 16:56:23]

PTAL Ken if you think this change is correct. Added Nico to verify my CL is
doing what I intended in the description.

[Nico, 2016-05-25 16:57:54]

https://codereview.chromium.org/2013683004/diff/1/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/2013683004/diff/1/tools/mb/mb_config.pyl#newc...
tools/mb/mb_config.pyl:2199: 'mixins': ['release_bot_minimal_symbols',
'dcheck_always_on'],
release_trybot already has dcheck_always_on as you can see here. release_bot
doesn't (see 5 lines above this line)

[Jamie Madill, 2016-05-25 17:58:18]

Description was changed from

==========
Use dcheck_always_on for all Release GPU bots.

This line enables assert failures in Release, a helpful thing for
testing. It may trigger some dormant failures that had been missed.

BUG=614725
R=kbr@chromium.org,thakis@chromium.org
==========

to

==========
Use dcheck_always_on for GPU FYI Release trybots.

This bot config was using release_bot instead of release_trybot. This
will enable asserts in release code for these configs.

BUG=614725
R=kbr@chromium.org,thakis@chromium.org
==========

[Jamie Madill, 2016-05-25 17:59:21]

On 2016/05/25 16:57:54, Nico wrote:
> https://codereview.chromium.org/2013683004/diff/1/tools/mb/mb_config.pyl
> File tools/mb/mb_config.pyl (right):
> 
>
https://codereview.chromium.org/2013683004/diff/1/tools/mb/mb_config.pyl#newc...
> tools/mb/mb_config.pyl:2199: 'mixins': ['release_bot_minimal_symbols',
> 'dcheck_always_on'],
> release_trybot already has dcheck_always_on as you can see here. release_bot
> doesn't (see 5 lines above this line)

Thanks, this makes a lot more sense now. PTAL, I think only one config was
broken.

[Nico, 2016-05-25 18:04:55]

lgtm if the answer below is "yes"

https://codereview.chromium.org/2013683004/diff/20001/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/2013683004/diff/20001/tools/mb/mb_config.pyl#...
tools/mb/mb_config.pyl:256: 'GPU Linux Builder':
'swarming_gpu_fyi_tests_gn_release_trybot',
The config is used by this other bot too. You want to change the config here
too, yes?

[Jamie Madill, 2016-05-25 18:13:26]

https://codereview.chromium.org/2013683004/diff/20001/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/2013683004/diff/20001/tools/mb/mb_config.pyl#...
tools/mb/mb_config.pyl:256: 'GPU Linux Builder':
'swarming_gpu_fyi_tests_gn_release_trybot',
On 2016/05/25 18:04:55, Nico wrote:
> The config is used by this other bot too. You want to change the config here
> too, yes?

Pretty sure the answer is yes.

[Ken Russell (switch to Gerrit), 2016-05-25 20:23:57]

lgtm

https://codereview.chromium.org/2013683004/diff/20001/tools/mb/mb_config.pyl
File tools/mb/mb_config.pyl (right):

https://codereview.chromium.org/2013683004/diff/20001/tools/mb/mb_config.pyl#...
tools/mb/mb_config.pyl:256: 'GPU Linux Builder':
'swarming_gpu_fyi_tests_gn_release_trybot',
On 2016/05/25 18:13:26, Jamie Madill wrote:
> On 2016/05/25 18:04:55, Nico wrote:
> > The config is used by this other bot too. You want to change the config here
> > too, yes?
> 
> Pretty sure the answer is yes.

Agree, yes. We want dchecks on not only on the trybots but also the waterfall
bots.

[Jamie Madill, 2016-05-25 20:36:35]

The CQ bit was checked by jmadill@chromium.org

[commit-bot: I haz the power, 2016-05-25 20:37:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2013683004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2013683004/20001

[commit-bot: I haz the power, 2016-05-25 22:43:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-25 22:45:52]

Description was changed from

==========
Use dcheck_always_on for GPU FYI Release trybots.

This bot config was using release_bot instead of release_trybot. This
will enable asserts in release code for these configs.

BUG=614725
R=kbr@chromium.org,thakis@chromium.org
==========

to

==========
Use dcheck_always_on for GPU FYI Release trybots.

This bot config was using release_bot instead of release_trybot. This
will enable asserts in release code for these configs.

BUG=614725
R=kbr@chromium.org,thakis@chromium.org

Committed: https://crrev.com/de78a4363a52721a1a6e96d0eb71a7fbc1a52662
Cr-Commit-Position: refs/heads/master@{#396015}
==========

[commit-bot: I haz the power, 2016-05-25 22:45:53]

Patchset 2 (id:??) landed as
https://crrev.com/de78a4363a52721a1a6e96d0eb71a7fbc1a52662
Cr-Commit-Position: refs/heads/master@{#396015}