Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: base/memory/shared_memory_win.cc

Issue 2013623003: Add more debugging to figure out why SharedMemory creation in the browser process might fail. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/memory/shared_memory_win.cc
diff --git a/base/memory/shared_memory_win.cc b/base/memory/shared_memory_win.cc
index 6623e8caefde4b74157be1723414706418374f0f..c4b426f5c4979ef30fab42f87a5b4c62ba601f03 100644
--- a/base/memory/shared_memory_win.cc
+++ b/base/memory/shared_memory_win.cc
@@ -377,6 +377,10 @@ bool SharedMemory::ShareToProcessCommon(ProcessHandle process,
if (!::DuplicateHandle(GetCurrentProcess(), mapped_file, process, &result,
access, FALSE, options)) {
+ // Debugging to help track down https://crbug.com/585013
+ DWORD last_error = ::GetLastError();
+ base::debug::Alias(&last_error);
+ base::debug::DumpWithoutCrashing();
return false;
}
*new_handle = SharedMemoryHandle(result, base::GetProcId(process));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698