Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2013623002: Set channelCount and maxChannelCount correctly for OfflineAudioContext. (Closed)

Created:
4 years, 7 months ago by Raymond Toy
Modified:
4 years, 7 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews, haraken, hongchan, Raymond Toy
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set channelCount and maxChannelCount correctly for OfflineAudioContext. Set the channelCount and maxChannelCount to the number of channels specified when creating the offline context. Also, we were not correctly setting the channelCountMode to "explicit", as required by the spec. BUG=612483 TEST=offlineaudiocontext-constructor.html Committed: https://crrev.com/9beda74dbeb23068d79e76a2706cfcb65c8c5e6a Cr-Commit-Position: refs/heads/master@{#396110}

Patch Set 1 #

Patch Set 2 : Add test #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/offlineaudiocontext-constructor.html View 1 2 3 1 chunk +7 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/offlineaudiocontext-constructor-expected.txt View 1 2 3 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp View 1 2 3 4 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Raymond Toy
PTAL. I also took this opportunity to fix a typo in the original test where ...
4 years, 7 months ago (2016-05-25 18:14:00 UTC) #4
hongchan
lgtm
4 years, 7 months ago (2016-05-25 21:51:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013623002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013623002/80001
4 years, 7 months ago (2016-05-25 22:02:59 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 7 months ago (2016-05-26 03:53:36 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 03:54:50 UTC) #11
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/9beda74dbeb23068d79e76a2706cfcb65c8c5e6a
Cr-Commit-Position: refs/heads/master@{#396110}

Powered by Google App Engine
This is Rietveld 408576698