Introduce assert_selection() for editing tests

Introduce assert_selection() for editing tests

This patch introduces |assert_selection()| function to help writing editing test
cases with W3C test harness.

Using |assert_selection()|, we can write test cases for execCommand as below:

assert_selection(
    '<div conteneditable>^foo|</div>',
    'createLink abc',
    '<div conteneditable><a href="abc">foo</a></div>')

rather than sequence of |assert_equals()| for |Selection| and |innerHTML|.

More samples are found in crrev.com/2018463002

BUG=n/a
TEST=n/a; no behavior changes

Committed: https://crrev.com/4af8b92817a88711cb2d42807badcf356a90efb7
Cr-Commit-Position: refs/heads/master@{#396161}

[yosin_UTC9, 2016-05-26 08:00:16]

Description was changed from

==========
2016-05-26T16:46:56

BUG=
==========

to

==========
Introduce assert_selection() for editing tests

This patch introduces |assert_selection()| function to help writing editing test
cases with W3C test harness.

BUG=n/a
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2016-05-26 08:00:16]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2016-05-26 08:03:41]

Description was changed from

==========
Introduce assert_selection() for editing tests

This patch introduces |assert_selection()| function to help writing editing test
cases with W3C test harness.

BUG=n/a
TEST=n/a; no behavior changes
==========

to

==========
Introduce assert_selection() for editing tests

This patch introduces |assert_selection()| function to help writing editing test
cases with W3C test harness.

Using |assert_selection()|, we can write test cases for execCommand as below:

assert_selection(
    '<div conteneditable>^foo|</div>',
    'createLink abc',
    '<div conteneditable><a href="abc">foo</a></div>')

rather than sequence of |assert_equals()| for |Selection| and |innerHTML|.

BUG=n/a
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2016-05-26 08:04:46]

Description was changed from

==========
Introduce assert_selection() for editing tests

This patch introduces |assert_selection()| function to help writing editing test
cases with W3C test harness.

Using |assert_selection()|, we can write test cases for execCommand as below:

assert_selection(
    '<div conteneditable>^foo|</div>',
    'createLink abc',
    '<div conteneditable><a href="abc">foo</a></div>')

rather than sequence of |assert_equals()| for |Selection| and |innerHTML|.

BUG=n/a
TEST=n/a; no behavior changes
==========

to

==========
Introduce assert_selection() for editing tests

This patch introduces |assert_selection()| function to help writing editing test
cases with W3C test harness.

Using |assert_selection()|, we can write test cases for execCommand as below:

assert_selection(
    '<div conteneditable>^foo|</div>',
    'createLink abc',
    '<div conteneditable><a href="abc">foo</a></div>')

rather than sequence of |assert_equals()| for |Selection| and |innerHTML|.

More samples are found in crrev.com/2018463002

BUG=n/a
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2016-05-26 08:04:53]

PTAL

[tkent, 2016-05-26 08:23:14]

lgtm

https://codereview.chromium.org/2013603004/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/editing/assert_selection.js (right):

https://codereview.chromium.org/2013603004/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/assert_selection.js:338: const
END_TAG_OMISSIBLE_NAMES = new Set(['br', 'hr', 'img', 'input', 'wbr']);
Can we refer to HTML5_VOID_ELEMENTS defined in
imported/wpt/html/resources/common.js ?

[yosin_UTC9, 2016-05-26 08:52:09]

On 2016/05/26 at 08:23:14, tkent wrote:
> lgtm
> 
>
https://codereview.chromium.org/2013603004/diff/20001/third_party/WebKit/Layo...
> File third_party/WebKit/LayoutTests/editing/assert_selection.js (right):
> 
>
https://codereview.chromium.org/2013603004/diff/20001/third_party/WebKit/Layo...
> third_party/WebKit/LayoutTests/editing/assert_selection.js:338: const
END_TAG_OMISSIBLE_NAMES = new Set(['br', 'hr', 'img', 'input', 'wbr']);
> Can we refer to HTML5_VOID_ELEMENTS defined in
imported/wpt/html/resources/common.js ?

Good to know.
I updated to use it.

[yosin_UTC9, 2016-05-26 08:52:13]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2016-05-26 08:52:14]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/2013603004/#ps40001
(title: "2016-05-26T17:48:22")

[commit-bot: I haz the power, 2016-05-26 08:52:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2013603004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2013603004/40001

[yosin_UTC9, 2016-05-26 09:05:51]

The CQ bit was unchecked by yosin@chromium.org

[yosin_UTC9, 2016-05-26 09:11:27]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2016-05-26 09:11:28]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/2013603004/#ps60001
(title: "2016-05-26T18:10:04")

[commit-bot: I haz the power, 2016-05-26 09:11:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2013603004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2013603004/60001

[yosin_UTC9, 2016-05-26 09:18:33]

The CQ bit was unchecked by yosin@chromium.org

[yosin_UTC9, 2016-05-26 10:28:10]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2016-05-26 10:28:11]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/2013603004/#ps100001
(title: "2016-05-26T19:25:56")

[commit-bot: I haz the power, 2016-05-26 10:28:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2013603004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2013603004/100001

[commit-bot: I haz the power, 2016-05-26 11:29:24]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-05-26 11:30:40]

Description was changed from

==========
Introduce assert_selection() for editing tests

This patch introduces |assert_selection()| function to help writing editing test
cases with W3C test harness.

Using |assert_selection()|, we can write test cases for execCommand as below:

assert_selection(
    '<div conteneditable>^foo|</div>',
    'createLink abc',
    '<div conteneditable><a href="abc">foo</a></div>')

rather than sequence of |assert_equals()| for |Selection| and |innerHTML|.

More samples are found in crrev.com/2018463002

BUG=n/a
TEST=n/a; no behavior changes
==========

to

==========
Introduce assert_selection() for editing tests

This patch introduces |assert_selection()| function to help writing editing test
cases with W3C test harness.

Using |assert_selection()|, we can write test cases for execCommand as below:

assert_selection(
    '<div conteneditable>^foo|</div>',
    'createLink abc',
    '<div conteneditable><a href="abc">foo</a></div>')

rather than sequence of |assert_equals()| for |Selection| and |innerHTML|.

More samples are found in crrev.com/2018463002

BUG=n/a
TEST=n/a; no behavior changes

Committed: https://crrev.com/4af8b92817a88711cb2d42807badcf356a90efb7
Cr-Commit-Position: refs/heads/master@{#396161}
==========

[commit-bot: I haz the power, 2016-05-26 11:30:41]

Patchset 6 (id:??) landed as
https://crrev.com/4af8b92817a88711cb2d42807badcf356a90efb7
Cr-Commit-Position: refs/heads/master@{#396161}