Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2013603003: Move ContentChangeType enum to a separate file, so that WebGLRenderingContextBase.h doesn't need La… (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
Reviewers:
bajones, eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, haraken, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ContentChangeType enum to a separate file, so that WebGLRenderingContextBase.h doesn't need LayoutBoxModelObject.h BUG=614015 TBR=bajones@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/e89e5ab31c45584ce17265f883a8912488268720 Cr-Commit-Position: refs/heads/master@{#395934}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
A third_party/WebKit/Source/core/layout/ContentChangeType.h View 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h View 2 chunks +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (9 generated)
mstensho (USE GERRIT)
@eae - I think this one deserves review (no TBR).
4 years, 7 months ago (2016-05-25 12:26:08 UTC) #3
eae
Seems fine, thanks! LGTM
4 years, 7 months ago (2016-05-25 14:56:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013603003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013603003/1
4 years, 7 months ago (2016-05-25 14:56:54 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/189583)
4 years, 7 months ago (2016-05-25 15:02:53 UTC) #8
mstensho (USE GERRIT)
TBRing for trivial change in modules/webgl/
4 years, 7 months ago (2016-05-25 15:05:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013603003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013603003/1
4 years, 7 months ago (2016-05-25 15:06:16 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 18:14:38 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 18:17:10 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e89e5ab31c45584ce17265f883a8912488268720
Cr-Commit-Position: refs/heads/master@{#395934}

Powered by Google App Engine
This is Rietveld 408576698