chrome/browser/ui/cocoa/notifications/balloon_controller_unittest.mm - Issue 20136004: Allow partial update for notification update API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/notifications/balloon_controller_unittest.mm

Issue 20136004: Allow partial update for notification update API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix trybots Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/notifications/notification_ui_manager.h ('K') | « chrome/browser/ui/ash/screenshot_taker_unittest.cc ('k') | chrome/common/extensions/api/notifications.idl » ('j') | chrome/renderer/resources/extensions/notifications_custom_bindings.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/notifications/balloon_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/notifications/balloon_controller_unittest.mm b/chrome/browser/ui/cocoa/notifications/balloon_controller_unittest.mm

index 58c279f0aea9f78b06cfc79f0611bf4eae6f4bbc..8b0f2df60ec2f9e94ad85f1aaccd63d2e7c4a2b0 100644

--- a/chrome/browser/ui/cocoa/notifications/balloon_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/notifications/balloon_controller_unittest.mm

@@ -31,7 +31,10 @@ namespace {

class MockBalloonCollection : public BalloonCollection {

virtual void Add(const Notification& notification,

Profile* profile) OVERRIDE {}

- virtual bool DoesIdExist(const std::string& id) OVERRIDE { return false; }

+ virtual bool DoesIdExist(const std::string& id,

+ Notification* matched_notification) OVERRIDE {

+ return false;

+ }

virtual bool RemoveById(const std::string& id) OVERRIDE { return false; }

virtual bool RemoveBySourceOrigin(const GURL& origin) OVERRIDE {

return false;