chrome/browser/notifications/balloon_notification_ui_manager.h - Issue 20136004: Allow partial update for notification update API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/balloon_notification_ui_manager.h

Issue 20136004: Allow partial update for notification update API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add more tests per feedback Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/notifications/balloon_notification_ui_manager.h

diff --git a/chrome/browser/notifications/balloon_notification_ui_manager.h b/chrome/browser/notifications/balloon_notification_ui_manager.h

index 953891eb3899abf19c994fa5825f4c79641fa465..31be3fa4586d3a59845ee449aa6d677245c73a8e 100644

--- a/chrome/browser/notifications/balloon_notification_ui_manager.h

+++ b/chrome/browser/notifications/balloon_notification_ui_manager.h

@@ -34,7 +34,8 @@ class BalloonNotificationUIManager

void SetBalloonCollection(BalloonCollection* balloon_collection);

// NotificationUIManager:

- virtual bool DoesIdExist(const std::string& notification_id) OVERRIDE;

+ virtual const Notification* FindById(

+ const std::string& notification_id) const OVERRIDE;

virtual bool CancelById(const std::string& notification_id) OVERRIDE;

virtual std::set<std::string> GetAllIdsByProfileAndSourceOrigin(

Profile* profile,