Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3541)

Unified Diff: chrome/browser/notifications/balloon_notification_ui_manager.cc

Issue 20136004: Allow partial update for notification update API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add more tests per feedback Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/balloon_notification_ui_manager.cc
diff --git a/chrome/browser/notifications/balloon_notification_ui_manager.cc b/chrome/browser/notifications/balloon_notification_ui_manager.cc
index d6ea75e5b5a41ba1a48b90715d3255057bc202f8..e19b4f68c82e7bff9921640364a5b843333dd5a9 100644
--- a/chrome/browser/notifications/balloon_notification_ui_manager.cc
+++ b/chrome/browser/notifications/balloon_notification_ui_manager.cc
@@ -44,10 +44,12 @@ void BalloonNotificationUIManager::SetBalloonCollection(
balloon_collection_->set_space_change_listener(this);
}
-bool BalloonNotificationUIManager::DoesIdExist(const std::string& id) {
- if (NotificationUIManagerImpl::DoesIdExist(id))
- return true;
- return balloon_collection_->DoesIdExist(id);
+const Notification* BalloonNotificationUIManager::FindById(
+ const std::string& id) const {
+ const Notification* notification = NotificationUIManagerImpl::FindById(id);
+ if (notification)
+ return notification;
+ return balloon_collection_->FindById(id);
}
bool BalloonNotificationUIManager::CancelById(const std::string& id) {

Powered by Google App Engine
This is Rietveld 408576698