chrome/browser/notifications/balloon_collection_impl.h - Issue 20136004: Allow partial update for notification update API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/balloon_collection_impl.h

Issue 20136004: Allow partial update for notification update API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add more tests per feedback Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/notifications/balloon_collection_impl.h

diff --git a/chrome/browser/notifications/balloon_collection_impl.h b/chrome/browser/notifications/balloon_collection_impl.h

index 45b26d0a24b37715f3c55e7fa3c997d4bb7a6db8..4a006fb135605cb25e76c368af58aff87ff8b9e7 100644

--- a/chrome/browser/notifications/balloon_collection_impl.h

+++ b/chrome/browser/notifications/balloon_collection_impl.h

@@ -46,7 +46,7 @@ class BalloonCollectionImpl : public BalloonCollection,

// BalloonCollection interface.

virtual void Add(const Notification& notification,

Profile* profile) OVERRIDE;

- virtual bool DoesIdExist(const std::string& id) OVERRIDE;

+ virtual const Notification* FindById(const std::string& id) const OVERRIDE;

virtual bool RemoveById(const std::string& id) OVERRIDE;

virtual bool RemoveBySourceOrigin(const GURL& source_origin) OVERRIDE;

virtual bool RemoveByProfile(Profile* profile) OVERRIDE;