Catch CSP violations in InProcessBrowserTest

chrome/test/base/in_process_browser_test.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/base/in_process_browser_test.h"
 
 #include "ash/common/ash_switches.h"
 #include "base/auto_reset.h"
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 114 matching lines @@
     "var error = '';"
     "for (var i = 0; i < result.length; ++i) {"
     "  if (result[i].result == axs.constants.AuditResult.FAIL) {"
     "    error = axs.Audit.createReport(result);"
     "    break;"
     "  }"
     "}"
     "domAutomationController.send(error);";
 
 InProcessBrowserTest::InProcessBrowserTest()
-    : browser_(NULL),
+    : browser_(nullptr),
       exit_when_last_browser_closes_(true),
       open_about_blank_on_browser_launch_(true),
+      expect_csp_messages_(false),
+      console_delegate_(nullptr),
       run_accessibility_checks_for_test_case_(false)
 #if defined(OS_MACOSX)
-      , autorelease_pool_(NULL)
+      , autorelease_pool_(nullptr)
 #endif  // OS_MACOSX
     {
 #if defined(OS_MACOSX)
   // TODO(phajdan.jr): Make browser_tests self-contained on Mac, remove this.
   // Before we run the browser, we have to hack the path to the exe to match
   // what it would be if Chrome was running, because it is used to fork renderer
   // processes, on Linux at least (failure to do so will cause a browser_test to
   // be run instead of a renderer).
   base::FilePath chrome_path;
   CHECK(PathService::Get(base::FILE_EXE, &chrome_path));
@@ skipping 15 matching lines @@
 #if defined(OS_MACOSX)
   bundle_swizzler_.reset(new ScopedBundleSwizzlerMac);
 #endif
 
 #if defined(USE_ASH)
   DefaultAshEventGeneratorDelegate::GetInstance();
 #endif
 }
 
 InProcessBrowserTest::~InProcessBrowserTest() {
+  // Make sure console_delegate_ is active in a function that's guaranteed
+  // to be called. RunTestOnMainThreadLoop() could be overriden.
+  CHECK(console_delegate_);
+  delete console_delegate_;
 }
 
 void InProcessBrowserTest::SetUp() {
   // Browser tests will create their own g_browser_process later.
   DCHECK(!g_browser_process);
 
   // Clear the FeatureList instance from base/test/test_suite.cc. Since this is
   // a browser test, a FeatureList will be registered as part of normal browser
   // start up in ChromeBrowserMainParts::SetupMetricsAndFieldTrials().
   base::FeatureList::ClearInstanceForTesting();
@@ skipping 210 matching lines @@
     int index,
     const GURL& url,
     ui::PageTransition transition) {
   AddTabAtIndexToBrowser(browser(), index, url, transition, true);
 }
 
 bool InProcessBrowserTest::SetUpUserDataDirectory() {
   return true;
 }
 
+void InProcessBrowserTest::SetExpectCSPErrorMessages(bool expect) {
+  expect_csp_messages_ = expect;
+}
+
 #if !defined(OS_MACOSX)
 void InProcessBrowserTest::OpenDevToolsWindow(
     content::WebContents* web_contents) {
   ASSERT_FALSE(content::DevToolsAgentHost::HasFor(web_contents));
   DevToolsWindow::OpenDevToolsWindow(web_contents);
   ASSERT_TRUE(content::DevToolsAgentHost::HasFor(web_contents));
 }
 
 Browser* InProcessBrowserTest::OpenURLOffTheRecord(Profile* profile,
                                                    const GURL& url) {
@@ skipping 112 matching lines @@
 
   // Pump any pending events that were created as a result of creating a
   // browser.
   content::RunAllPendingInMessageLoop();
 
   // run_accessibility_checks_for_test_case_ must be set before calling
   // SetUpOnMainThread or RunTestOnMainThread so that one or all tests can
   // enable/disable the accessibility audit.
   run_accessibility_checks_for_test_case_ = false;
 
+  // Set up console message listener to look for CSP error messages.
+  content::WebContents* web_contents =
+      browser()->tab_strip_model()->GetActiveWebContents();
+  console_delegate_ = new content::ConsoleObserverDelegate(
+          web_contents,
+          "*Content Security Policy*");
+  web_contents->SetDelegate(console_delegate_);
+
   SetUpOnMainThread();
 #if defined(OS_MACOSX)
   autorelease_pool_->Recycle();
 #endif
 
   if (!HasFatalFailure())
     RunTestOnMainThread();
 #if defined(OS_MACOSX)
   autorelease_pool_->Recycle();
 #endif
 
   if (run_accessibility_checks_for_test_case_) {
     std::string error_message;
     EXPECT_TRUE(RunAccessibilityChecks(&error_message));
     EXPECT_EQ("", error_message);
   }
 
   // Invoke cleanup and quit even if there are failures. This is similar to
   // gtest in that it invokes TearDown even if Setup fails.
   TearDownOnMainThread();
 #if defined(OS_MACOSX)
   autorelease_pool_->Recycle();
 #endif
 
+  // Check CSP error messages.
+  if (expect_csp_messages_) {
+    EXPECT_NE("", console_delegate_->message());
+  } else {
+    EXPECT_EQ("", console_delegate_->message());
+  }
+
   // Sometimes tests leave Quit tasks in the MessageLoop (for shame), so let's
   // run all pending messages here to avoid preempting the QuitBrowsers tasks.
   // TODO(jbates) Once crbug.com/134753 is fixed, this can be removed because it
   // will not be possible to post Quit tasks.
   content::RunAllPendingInMessageLoop();
 
   QuitBrowsers();
   // BrowserList should be empty at this point.
   CHECK(BrowserList::GetInstance()->empty());
 }
@@ skipping 16 matching lines @@
   // their tab contents. The last tab contents being removed triggers closing of
   // the browser window.
   //
   // On the Mac, this eventually reaches
   // -[BrowserWindowController windowWillClose:], which will post a deferred
   // -autorelease on itself to ultimately destroy the Browser object. The line
   // below is necessary to pump these pending messages to ensure all Browsers
   // get deleted.
   content::RunAllPendingInMessageLoop();
   delete autorelease_pool_;
-  autorelease_pool_ = NULL;
+  autorelease_pool_ = nullptr;
 #endif
 }