Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: chrome/browser/extensions/api/notifications/notifications_apitest.cc

Issue 2013573007: Catch CSP violations in InProcessBrowserTest Base URL: https://chromium.googlesource.com/a/chromium/src.git@master
Patch Set: double check test is run Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/strings/string_number_conversions.h" 5 #include "base/strings/string_number_conversions.h"
6 #include "base/strings/stringprintf.h" 6 #include "base/strings/stringprintf.h"
7 #include "base/strings/utf_string_conversions.h" 7 #include "base/strings/utf_string_conversions.h"
8 #include "chrome/browser/browser_process.h" 8 #include "chrome/browser/browser_process.h"
9 #include "chrome/browser/extensions/api/notifications/notifications_api.h" 9 #include "chrome/browser/extensions/api/notifications/notifications_api.h"
10 #include "chrome/browser/extensions/extension_apitest.h" 10 #include "chrome/browser/extensions/extension_apitest.h"
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 IN_PROC_BROWSER_TEST_F(NotificationsApiTest, TestBasicUsage) { 112 IN_PROC_BROWSER_TEST_F(NotificationsApiTest, TestBasicUsage) {
113 ASSERT_TRUE(RunExtensionTest("notifications/api/basic_usage")) << message_; 113 ASSERT_TRUE(RunExtensionTest("notifications/api/basic_usage")) << message_;
114 } 114 }
115 115
116 IN_PROC_BROWSER_TEST_F(NotificationsApiTest, TestEvents) { 116 IN_PROC_BROWSER_TEST_F(NotificationsApiTest, TestEvents) {
117 ASSERT_TRUE(RunExtensionTest("notifications/api/events")) << message_; 117 ASSERT_TRUE(RunExtensionTest("notifications/api/events")) << message_;
118 } 118 }
119 119
120 IN_PROC_BROWSER_TEST_F(NotificationsApiTest, TestCSP) { 120 IN_PROC_BROWSER_TEST_F(NotificationsApiTest, TestCSP) {
121 ASSERT_TRUE(RunExtensionTest("notifications/api/csp")) << message_; 121 ASSERT_TRUE(RunExtensionTest("notifications/api/csp")) << message_;
122 // The violation is not intentional. See crbug.com/616181
123 SetExpectCSPErrorMessages(true);
122 } 124 }
123 125
124 IN_PROC_BROWSER_TEST_F(NotificationsApiTest, TestByUser) { 126 IN_PROC_BROWSER_TEST_F(NotificationsApiTest, TestByUser) {
125 const extensions::Extension* extension = 127 const extensions::Extension* extension =
126 LoadExtensionAndWait("notifications/api/by_user"); 128 LoadExtensionAndWait("notifications/api/by_user");
127 ASSERT_TRUE(extension) << message_; 129 ASSERT_TRUE(extension) << message_;
128 130
129 { 131 {
130 ResultCatcher catcher; 132 ResultCatcher catcher;
131 const std::string notification_id = 133 const std::string notification_id =
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
295 ASSERT_TRUE(extension) << message_; 297 ASSERT_TRUE(extension) << message_;
296 298
297 const message_center::NotificationList::Notifications& notifications = 299 const message_center::NotificationList::Notifications& notifications =
298 g_browser_process->message_center()->GetVisibleNotifications(); 300 g_browser_process->message_center()->GetVisibleNotifications();
299 ASSERT_EQ(1u, notifications.size()); 301 ASSERT_EQ(1u, notifications.size());
300 message_center::Notification* notification = *(notifications.begin()); 302 message_center::Notification* notification = *(notifications.begin());
301 ASSERT_EQ(extension->url(), notification->origin_url()); 303 ASSERT_EQ(extension->url(), notification->origin_url());
302 304
303 EXPECT_TRUE(notification->never_timeout()); 305 EXPECT_TRUE(notification->never_timeout());
304 } 306 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698