Catch CSP violations in InProcessBrowserTest

chrome/test/base/in_process_browser_test.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_TEST_BASE_IN_PROCESS_BROWSER_TEST_H_
 #define CHROME_TEST_BASE_IN_PROCESS_BROWSER_TEST_H_
 
 #include <memory>
 
 #include "base/compiler_specific.h"
@@ skipping 140 matching lines @@
   // it should override this method.
   virtual void SetUpDefaultCommandLine(base::CommandLine* command_line);
 
   // Initializes the contents of the user data directory. Called by SetUp()
   // after creating the user data directory, but before any browser is launched.
   // If a test wishes to set up some initial non-empty state in the user data
   // directory before the browser starts up, it can do so here. Returns true if
   // successful.
   virtual bool SetUpUserDataDirectory() WARN_UNUSED_RESULT;
 
+  // In TearDown(), it is asserted CSP error messages never show up during
+  // the test. If you are sure these errors can be ignored, override this.
+  virtual void SetIgnoreCSPErrorMessages(bool ignore);

[Tom Sepez, 2016/05/31 16:21:38]

Instead, how about SetExpectCSPErrorMessages(bool)?  Then, during teardown you
can fail the test if none occurred.  Otherwise, fail the test if any occured.

[wychen, 2016/06/08 05:41:57]

Done.

+
   // BrowserTestBase:
   void RunTestOnMainThreadLoop() override;
 
   // Ensures that no devtools are open, and then opens the devtools.
   void OpenDevToolsWindow(content::WebContents* web_contents);
 
   // Opens |url| in an incognito browser window with the incognito profile of
   // |profile|, blocking until the navigation finishes. This will create a new
   // browser if a browser with the incognito profile does not exist. Returns the
   // incognito window Browser.
@@ skipping 69 matching lines @@
   // Temporary user data directory. Used only when a user data directory is not
   // specified in the command line.
   base::ScopedTempDir temp_user_data_dir_;
 
   // True if we should exit the tests after the last browser instance closes.
   bool exit_when_last_browser_closes_;
 
   // True if the about:blank tab should be opened when the browser is launched.
   bool open_about_blank_on_browser_launch_;
 
+

[mdjones, 2016/06/08 16:57:04]

nit: extra line.

+  // True if CSP error messages can be ignored. Otherwise fail the test.
+  bool ignore_csp_messages_;
   // True if the accessibility test should run for a particular test case.
   // This is reset for every test case.
   bool run_accessibility_checks_for_test_case_;
 
 #if defined(OS_MACOSX)
   base::mac::ScopedNSAutoreleasePool* autorelease_pool_;
   std::unique_ptr<ScopedBundleSwizzlerMac> bundle_swizzler_;
 #endif  // OS_MACOSX
 
 #if defined(OS_WIN)
   std::unique_ptr<base::win::ScopedCOMInitializer> com_initializer_;
 #endif
 };
 
 #endif  // CHROME_TEST_BASE_IN_PROCESS_BROWSER_TEST_H_