Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 2013573004: [Interpreter] Inline test and compare binary ops. (Closed)

Created:
4 years, 7 months ago by rmcilroy
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Inline test and compare binary ops. This inlines the test and compare binary operations into Ignition. With this CL all binary ops are inlined into Ignition's bytecode handlers. Some blocks were shuffled around in Equals/NotEquals stubs to avoid creating frames unecessarily. Some labels were also marked as non- deferred in both Equals/NotEquals and the AbstractRelationalComparison stubs for the same reason. BUG=v8:4280 LOG=N Committed: https://crrev.com/b890d8c43e82a980ed0c9434c4674e1feba9d4ee Cr-Commit-Position: refs/heads/master@{#36542}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -137 lines) Patch
M src/code-stubs.h View 10 chunks +10 lines, -10 lines 0 comments Download
M src/code-stubs.cc View 30 chunks +195 lines, -101 lines 0 comments Download
M src/interpreter/interpreter.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/interpreter/interpreter.cc View 6 chunks +9 lines, -23 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013573004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013573004/1
4 years, 7 months ago (2016-05-25 11:02:23 UTC) #2
rmcilroy
Benedkit, please review changes to code-stubs. Mythri, please review changes to interpreter. Thanks.
4 years, 7 months ago (2016-05-25 11:27:59 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-25 12:18:54 UTC) #6
commit-bot: I haz the power
Dry run: None
4 years, 7 months ago (2016-05-25 12:19:01 UTC) #7
mythria
lgtm
4 years, 7 months ago (2016-05-26 13:39:38 UTC) #8
Benedikt Meurer
lgtm
4 years, 6 months ago (2016-05-27 03:55:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013573004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013573004/1
4 years, 6 months ago (2016-05-27 09:28:02 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-27 09:54:56 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 09:57:17 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b890d8c43e82a980ed0c9434c4674e1feba9d4ee
Cr-Commit-Position: refs/heads/master@{#36542}

Powered by Google App Engine
This is Rietveld 408576698