Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2013573002: Avoid hiding --type=gpu-process (Closed)

Created:
4 years, 7 months ago by brucedawson
Modified:
4 years, 7 months ago
Reviewers:
erikchen, jbauman
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, erikchen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid hiding --type=gpu-process Move FeaturesAndFieldTrialFlags to the end of the gpu-process command line to avoid breaking the pattern and to make process-type identification easier (and more reliable from ETW traces). BUG=614502 Committed: https://crrev.com/3089deef0bd591b699841f9b6b7cc9cd6ec88117 Cr-Commit-Position: refs/heads/master@{#395742}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/gpu/gpu_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
brucedawson
PTAL
4 years, 7 months ago (2016-05-24 23:40:31 UTC) #2
erikchen
lgtm
4 years, 7 months ago (2016-05-24 23:42:39 UTC) #4
brucedawson
Changing owner reviewers. jbauman - PTAL?
4 years, 7 months ago (2016-05-24 23:48:44 UTC) #7
jbauman
lgtm
4 years, 7 months ago (2016-05-24 23:51:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013573002/1
4 years, 7 months ago (2016-05-24 23:53:00 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 23:57:57 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 23:59:02 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3089deef0bd591b699841f9b6b7cc9cd6ec88117
Cr-Commit-Position: refs/heads/master@{#395742}

Powered by Google App Engine
This is Rietveld 408576698