Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2013553002: [Tracing] Export TraceConfig to model.metadata (Closed)

Created:
4 years, 7 months ago by nednguyen
Modified:
4 years, 7 months ago
Reviewers:
benjhayden, fmeawad
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Base URL:
https://github.com/catapult-project/catapult@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Fadi's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M tracing/tracing/extras/importer/trace_event_importer.html View 1 chunk +3 lines, -0 lines 0 comments Download
M tracing/tracing/extras/importer/trace_event_importer_test.html View 1 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
nednguyen
4 years, 7 months ago (2016-05-24 20:52:18 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013553002/1
4 years, 7 months ago (2016-05-24 20:52:40 UTC) #4
fmeawad
https://codereview.chromium.org/2013553002/diff/1/tracing/tracing/extras/importer/trace_event_importer_test.html File tracing/tracing/extras/importer/trace_event_importer_test.html (right): https://codereview.chromium.org/2013553002/diff/1/tracing/tracing/extras/importer/trace_event_importer_test.html#newcode5311 tracing/tracing/extras/importer/trace_event_importer_test.html:5311: { name: 'TraceConfig', args: {value: traceConfigData }, Can you ...
4 years, 7 months ago (2016-05-24 21:03:51 UTC) #5
nednguyen
https://codereview.chromium.org/2013553002/diff/1/tracing/tracing/extras/importer/trace_event_importer_test.html File tracing/tracing/extras/importer/trace_event_importer_test.html (right): https://codereview.chromium.org/2013553002/diff/1/tracing/tracing/extras/importer/trace_event_importer_test.html#newcode5311 tracing/tracing/extras/importer/trace_event_importer_test.html:5311: { name: 'TraceConfig', args: {value: traceConfigData }, On 2016/05/24 ...
4 years, 7 months ago (2016-05-24 21:11:51 UTC) #6
fmeawad
lgtm
4 years, 7 months ago (2016-05-24 21:17:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2013553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2013553002/20001
4 years, 7 months ago (2016-05-24 21:20:33 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 21:42:31 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698