Optimize WebURL -> GURL conversions

public/platform/WebString.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 15 matching lines @@
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef WebString_h
 #define WebString_h
 
 #include "WebCommon.h"
 #include "WebPrivatePtr.h"
+#include <string>
 
 #if INSIDE_WEBKIT
 #include <wtf/Forward.h>
 #else
 #include <base/strings/latin1_string_conversions.h>
 #include <base/strings/nullable_string16.h>
 #include <base/strings/string16.h>
 #endif
 
 namespace WTF {
@@ skipping 26 matching lines @@
     {
         assign(s);
         return *this;
     }
 
     BLINK_COMMON_EXPORT void reset();
     BLINK_COMMON_EXPORT void assign(const WebString&);
     BLINK_COMMON_EXPORT void assign(const WebUChar* data, size_t len);
 
     BLINK_COMMON_EXPORT bool equals(const WebString&) const;
+    BLINK_COMMON_EXPORT bool lessThan(const WebString&) const;
 
     BLINK_COMMON_EXPORT size_t length() const;
 
     // Caller must check bounds.
     BLINK_COMMON_EXPORT WebUChar at(unsigned) const;
 
     bool isEmpty() const { return !length(); }
     bool isNull() const { return m_private.isNull(); }
 
     BLINK_COMMON_EXPORT WebCString utf8() const;
+    BLINK_COMMON_EXPORT std::string toUTF8String() const;

[abarth-chromium, 2013/07/24 21:59:10]

I'm not super happy with this name...  Open to suggestions.  ;)

[Jeffrey Yasskin, 2013/07/24 22:23:20]

It would be clearer if it mentioned "std", but it doesn't seem terrible to me as
it is.

 
     BLINK_COMMON_EXPORT static WebString fromUTF8(const char* data, size_t length);
     BLINK_COMMON_EXPORT static WebString fromUTF8(const char* data);
 
     template <int N> WebString(const char (&data)[N])
     {
         assign(fromUTF8(data, N - 1));
     }
 
     template <int N> WebString& operator=(const char (&data)[N])
@@ skipping 60 matching lines @@
 private:
     BLINK_COMMON_EXPORT bool is8Bit() const;
     BLINK_COMMON_EXPORT const WebLChar* data8() const;
     BLINK_COMMON_EXPORT const WebUChar* data16() const;
 
     BLINK_COMMON_EXPORT void assign(WTF::StringImpl*);
 
     WebPrivatePtr<WTF::StringImpl> m_private;
 };
 
+inline bool operator<(const WebString& a, const WebString& b)
+{
+    return a.lessThan(b);
+}
+
 inline bool operator==(const WebString& a, const WebString& b)
 {
     return a.equals(b);
 }
 
 inline bool operator!=(const WebString& a, const WebString& b)
 {
     return !(a == b);
 }
 
 } // namespace WebKit
 
 #endif