Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Side by Side Diff: Source/weborigin/KURL.h

Issue 20135002: Optimize WebURL -> GURL conversions (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/platform/chromium/support/WebURL.cpp ('k') | Source/weborigin/KURL.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2011, 2012 Apple Inc. All r ights reserved. 2 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2011, 2012 Apple Inc. All r ights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 // absolute. 72 // absolute.
73 // FIXME: If the base URL is invalid, this always creates an invalid 73 // FIXME: If the base URL is invalid, this always creates an invalid
74 // URL. Instead I think it would be better to treat all invalid base URLs 74 // URL. Instead I think it would be better to treat all invalid base URLs
75 // the same way we treate null and empty base URLs. 75 // the same way we treate null and empty base URLs.
76 KURL(const KURL& base, const String& relative); 76 KURL(const KURL& base, const String& relative);
77 KURL(const KURL& base, const String& relative, const WTF::TextEncoding&); 77 KURL(const KURL& base, const String& relative, const WTF::TextEncoding&);
78 78
79 // For conversions from other structures that have already parsed and 79 // For conversions from other structures that have already parsed and
80 // canonicalized the URL. The input must be exactly what KURL would have 80 // canonicalized the URL. The input must be exactly what KURL would have
81 // done with the same input. 81 // done with the same input.
82 KURL(const CString& canonicalSpec, const url_parse::Parsed&, bool isValid); 82 KURL(const AtomicString& canonicalString, const url_parse::Parsed&, bool isV alid);
83 83
84 String strippedForUseAsReferrer() const; 84 String strippedForUseAsReferrer() const;
85 85
86 // FIXME: The above functions should be harmonized so that passing a 86 // FIXME: The above functions should be harmonized so that passing a
87 // base of null or the empty string gives the same result as the 87 // base of null or the empty string gives the same result as the
88 // standard String constructor. 88 // standard String constructor.
89 89
90 // Makes a deep copy. Helpful only if you need to use a KURL on another 90 // Makes a deep copy. Helpful only if you need to use a KURL on another
91 // thread. Since the underlying StringImpl objects are immutable, there's 91 // thread. Since the underlying StringImpl objects are immutable, there's
92 // no other reason to ever prefer copy() over plain old assignment. 92 // no other reason to ever prefer copy() over plain old assignment.
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
266 266
267 // KURLHash is the default hash for String 267 // KURLHash is the default hash for String
268 template<typename T> struct DefaultHash; 268 template<typename T> struct DefaultHash;
269 template<> struct DefaultHash<WebCore::KURL> { 269 template<> struct DefaultHash<WebCore::KURL> {
270 typedef WebCore::KURLHash Hash; 270 typedef WebCore::KURLHash Hash;
271 }; 271 };
272 272
273 } // namespace WTF 273 } // namespace WTF
274 274
275 #endif // KURL_h 275 #endif // KURL_h
OLDNEW
« no previous file with comments | « Source/core/platform/chromium/support/WebURL.cpp ('k') | Source/weborigin/KURL.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698