Optimize WebURL -> GURL conversions

public/platform/WebString.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 15 matching lines @@
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef WebString_h
 #define WebString_h
 
 #include "WebCommon.h"
 #include "WebPrivatePtr.h"
+#include <string>
 
 #if INSIDE_WEBKIT
 #include <wtf/Forward.h>
 #else
 #include <base/strings/latin1_string_conversions.h>
 #include <base/strings/nullable_string16.h>
 #include <base/strings/string16.h>
 #endif
 
 namespace WTF {
@@ skipping 36 matching lines @@
 
     BLINK_COMMON_EXPORT size_t length() const;
 
     // Caller must check bounds.
     BLINK_COMMON_EXPORT WebUChar at(unsigned) const;
 
     bool isEmpty() const { return !length(); }
     bool isNull() const { return m_private.isNull(); }
 
     BLINK_COMMON_EXPORT WebCString utf8() const;
+    BLINK_COMMON_EXPORT std::string toUTF8String() const;

[darin (slow to review), 2013/07/24 23:16:51]

This is sort of a new thing for us.  There's a lot of places in Chromium that
use the .utf8() accessor when they really want a std::string.  It might be nice
if the thing that everyone should be using instead had the shorter name.  Hmm...

[abarth-chromium, 2013/07/24 23:22:43]

Yes.  I suspect most (all?) the callers of WebString::utf8 should be moved over
to this API...  We could name it toUTF8 (to mirror the fromUTF8 API) and then
delete utf8.  If we want to use the utf8 name, we'll need to move everyone to a
temporary name while we change all the callers.

 
     BLINK_COMMON_EXPORT static WebString fromUTF8(const char* data, size_t length);
     BLINK_COMMON_EXPORT static WebString fromUTF8(const char* data);
 
     template <int N> WebString(const char (&data)[N])
     {
         assign(fromUTF8(data, N - 1));
     }
 
     template <int N> WebString& operator=(const char (&data)[N])
@@ skipping 73 matching lines @@
 }
 
 inline bool operator!=(const WebString& a, const WebString& b)
 {
     return !(a == b);
 }
 
 } // namespace WebKit
 
 #endif