Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: headless/lib/browser/headless_browser_impl.h

Issue 2013483002: headless: Make HeadlessBrowser::Options move-only (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « headless/lib/browser/headless_browser_context.cc ('k') | headless/lib/browser/headless_browser_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: headless/lib/browser/headless_browser_impl.h
diff --git a/headless/lib/browser/headless_browser_impl.h b/headless/lib/browser/headless_browser_impl.h
index 53bcf1385ac5ce0a380bfe692c73de955d1d1c37..95332ac14ecec153ca8fbd8807301ca117ddd2ed 100644
--- a/headless/lib/browser/headless_browser_impl.h
+++ b/headless/lib/browser/headless_browser_impl.h
@@ -30,7 +30,7 @@ class HeadlessBrowserImpl : public HeadlessBrowser {
public:
HeadlessBrowserImpl(
const base::Callback<void(HeadlessBrowser*)>& on_start_callback,
- const HeadlessBrowser::Options& options);
+ HeadlessBrowser::Options options);
~HeadlessBrowserImpl() override;
// HeadlessBrowser implementation:
@@ -50,7 +50,7 @@ class HeadlessBrowserImpl : public HeadlessBrowser {
void RunOnStartCallback();
- const HeadlessBrowser::Options& options() const { return options_; }
+ HeadlessBrowser::Options* options() { return &options_; }
HeadlessWebContentsImpl* RegisterWebContents(
std::unique_ptr<HeadlessWebContentsImpl> web_contents);
@@ -61,7 +61,7 @@ class HeadlessBrowserImpl : public HeadlessBrowser {
// Customize the options used by this headless browser instance. Note that
// options which take effect before the message loop has been started (e.g.,
// custom message pumps) cannot be set via this method.
- void SetOptionsForTesting(const HeadlessBrowser::Options& options);
+ void SetOptionsForTesting(HeadlessBrowser::Options options);
protected:
base::Callback<void(HeadlessBrowser*)> on_start_callback_;
« no previous file with comments | « headless/lib/browser/headless_browser_context.cc ('k') | headless/lib/browser/headless_browser_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698